Skip to content

Don't crash when running cargo profdata --help #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therealprof merged 1 commit into from
Sep 26, 2025
Merged

Don't crash when running cargo profdata --help #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 16 additions & 13 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,10 @@ To see all the flags the proxied tool accepts run `cargo-{} -- --help`.{}",
.last(true)
.num_args(1..)
.help("The arguments to be proxied to the tool"),
// We look at .cargo/config.toml even when we don't build the binary.
Arg::new("manifest-path")
.long("manifest-path")
.help("Path to Cargo.tom"),
])
.after_help(after_help);

Expand Down Expand Up @@ -223,9 +227,6 @@ To see all the flags the proxied tool accepts run `cargo-{} -- --help`.{}",
.long("profile")
.value_name("PROFILE-NAME")
.help("Build artifacts with the specified profile"),
Arg::new("manifest-path")
.long("manifest-path")
.help("Path to Cargo.tom"),
Arg::new("features")
.long("features")
.short('F')
Expand Down Expand Up @@ -280,16 +281,18 @@ To see all the flags the proxied tool accepts run `cargo-{} -- --help`.{}",

pub fn run(tool: Tool, matches: ArgMatches) -> Result<i32> {
let mut metadata_command = MetadataCommand::new();
if let Some(features) = matches.get_many::<String>("features") {
metadata_command.features(CargoOpt::SomeFeatures(
features.map(|s| s.to_owned()).collect(),
));
}
if matches.get_flag("no-default-features") {
metadata_command.features(CargoOpt::NoDefaultFeatures);
}
if matches.get_flag("all-features") {
metadata_command.features(CargoOpt::AllFeatures);
if tool.needs_build() {
if let Some(features) = matches.get_many::<String>("features") {
metadata_command.features(CargoOpt::SomeFeatures(
features.map(|s| s.to_owned()).collect(),
));
}
if matches.get_flag("no-default-features") {
metadata_command.features(CargoOpt::NoDefaultFeatures);
}
if matches.get_flag("all-features") {
metadata_command.features(CargoOpt::AllFeatures);
}
}
if let Some(path) = matches.get_one::<String>("manifest-path") {
metadata_command.manifest_path(path);
Expand Down
Loading