Skip to content

use cortex-m-types in NVIC#654

Draft
robamu wants to merge 3 commits intomasterfrom
use-cortex-m-types-in-nvic
Draft

use cortex-m-types in NVIC#654
robamu wants to merge 3 commits intomasterfrom
use-cortex-m-types-in-nvic

Conversation

@robamu
Copy link
Copy Markdown

@robamu robamu commented Apr 26, 2026

The InterruptNumber blanket impl for cortex_m_types::InterruptNumber is not compatible with the one for all types implementing bare_metal::Nr . removing the other blanket impl is probably a breaking change? :/

@adamgreig
Copy link
Copy Markdown
Member

Hah, shame we can't add an impl of bare_metal's Nr to cortex-m-types. Can we keep using cortex-m's old InterruptNumber trait in NVIC, and add an impl of InterruptNumber for anything implementing either bare_metal's Nr or cortex-m-type's InterruptNumber?

@robamu
Copy link
Copy Markdown
Author

robamu commented Apr 26, 2026

maybe, but I do not know how with my current Rust foo. I get conflicting implementation errors when I try do add a blanket impl for both of these types. The fundamental problem probably is that this is a breaking change, right?

At this point I wonder whether we just have to accept some transition pain and move forward with the breaking change. then I have to merge into a different branch. At the very least, PACs will not break anymore in the future, as long as everybody agrees on the same trait crate, right?

@robamu
Copy link
Copy Markdown
Author

robamu commented Apr 26, 2026

do we have a branch for breaking changes? drafted until it is decided how to continue..

@robamu
Copy link
Copy Markdown
Author

robamu commented Apr 26, 2026

I think the current CI failure is fixed by #653

@robamu robamu marked this pull request as draft April 26, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants