Conversation
|
Hah, shame we can't add an impl of bare_metal's Nr to cortex-m-types. Can we keep using cortex-m's old InterruptNumber trait in NVIC, and add an impl of InterruptNumber for anything implementing either bare_metal's Nr or cortex-m-type's InterruptNumber? |
|
maybe, but I do not know how with my current Rust foo. I get conflicting implementation errors when I try do add a blanket impl for both of these types. The fundamental problem probably is that this is a breaking change, right? At this point I wonder whether we just have to accept some transition pain and move forward with the breaking change. then I have to merge into a different branch. At the very least, PACs will not break anymore in the future, as long as everybody agrees on the same trait crate, right? |
|
do we have a branch for breaking changes? drafted until it is decided how to continue.. |
|
I think the current CI failure is fixed by #653 |
The InterruptNumber blanket impl for
cortex_m_types::InterruptNumberis not compatible with the one for all types implementing bare_metal::Nr . removing the other blanket impl is probably a breaking change? :/