fix: correct wrong error messages and a doc comment

aptgetgit · aptgetgit · commit ad0cf97b0eb2 · 2026-07-05T14:48:22.000+05:30
diff --git a/14_virtual_mem_part2_mmio_remap/kernel/src/memory.rs b/14_virtual_mem_part2_mmio_remap/kernel/src/memory.rs
@@ -101,7 +101,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/14_virtual_mem_part2_mmio_remap/kernel/src/memory/mmu/types.rs b/14_virtual_mem_part2_mmio_remap/kernel/src/memory/mmu/types.rs
@@ -172,7 +172,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }
diff --git a/15_virtual_mem_part3_precomputed_tables/kernel/src/bsp/raspberrypi/kernel.ld b/15_virtual_mem_part3_precomputed_tables/kernel/src/bsp/raspberrypi/kernel.ld
@@ -91,7 +91,7 @@ SECTIONS
     . += 8 * 1024 * 1024;
     __mmio_remap_end_exclusive = .;
 
-    ASSERT((. & PAGE_MASK) == 0, "End of boot core stack is not page aligned")
+    ASSERT((. & PAGE_MASK) == 0, "MMIO remap reservation is not page aligned")
 
     /***********************************************************************************************
     * Misc
diff --git a/15_virtual_mem_part3_precomputed_tables/kernel/src/memory.rs b/15_virtual_mem_part3_precomputed_tables/kernel/src/memory.rs
@@ -101,7 +101,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/15_virtual_mem_part3_precomputed_tables/kernel/src/memory/mmu/types.rs b/15_virtual_mem_part3_precomputed_tables/kernel/src/memory/mmu/types.rs
@@ -172,7 +172,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }
diff --git a/16_virtual_mem_part4_higher_half_kernel/kernel/src/memory.rs b/16_virtual_mem_part4_higher_half_kernel/kernel/src/memory.rs
@@ -101,7 +101,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/16_virtual_mem_part4_higher_half_kernel/kernel/src/memory/mmu/types.rs b/16_virtual_mem_part4_higher_half_kernel/kernel/src/memory/mmu/types.rs
@@ -177,7 +177,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }
diff --git a/17_kernel_symbols/kernel/src/memory.rs b/17_kernel_symbols/kernel/src/memory.rs
@@ -101,7 +101,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/17_kernel_symbols/kernel/src/memory/mmu/types.rs b/17_kernel_symbols/kernel/src/memory/mmu/types.rs
@@ -177,7 +177,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }
diff --git a/18_backtrace/kernel/src/memory.rs b/18_backtrace/kernel/src/memory.rs
@@ -101,7 +101,7 @@ impl<ATYPE: AddressType> Sub<usize> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: usize) -> Self::Output {
         match self.value.checked_sub(rhs) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
@@ -113,7 +113,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/18_backtrace/kernel/src/memory/mmu/types.rs b/18_backtrace/kernel/src/memory/mmu/types.rs
@@ -177,7 +177,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }
diff --git a/19_kernel_heap/kernel/src/memory.rs b/19_kernel_heap/kernel/src/memory.rs
@@ -102,7 +102,7 @@ impl<ATYPE: AddressType> Sub<usize> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: usize) -> Self::Output {
         match self.value.checked_sub(rhs) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
@@ -114,7 +114,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/19_kernel_heap/kernel/src/memory/mmu/types.rs b/19_kernel_heap/kernel/src/memory/mmu/types.rs
@@ -177,7 +177,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }
diff --git a/20_timer_callbacks/kernel/src/memory.rs b/20_timer_callbacks/kernel/src/memory.rs
@@ -102,7 +102,7 @@ impl<ATYPE: AddressType> Sub<usize> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: usize) -> Self::Output {
         match self.value.checked_sub(rhs) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
@@ -114,7 +114,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {
     #[inline(always)]
     fn sub(self, rhs: Address<ATYPE>) -> Self::Output {
         match self.value.checked_sub(rhs.value) {
-            None => panic!("Overflow on Address::sub"),
+            None => panic!("Underflow on Address::sub"),
             Some(x) => Self::new(x),
         }
     }
diff --git a/20_timer_callbacks/kernel/src/memory/mmu/types.rs b/20_timer_callbacks/kernel/src/memory/mmu/types.rs
@@ -177,7 +177,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {
         self.end_exclusive
     }
 
-    /// Returns the exclusive end page address.
+    /// Returns the inclusive end page address.
     pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {
         self.end_exclusive.checked_offset(-1).unwrap()
     }

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ impl<ATYPE: AddressType> Sub<Address<ATYPE>> for Address<ATYPE> {`
`101`	`101`	`#[inline(always)]`
`102`	`102`	`fn sub(self, rhs: Address<ATYPE>) -> Self::Output {`
`103`	`103`	`match self.value.checked_sub(rhs.value) {`
`104`		`- None => panic!("Overflow on Address::sub"),`
	`104`	`+ None => panic!("Underflow on Address::sub"),`
`105`	`105`	`Some(x) => Self::new(x),`
`106`	`106`	`}`
`107`	`107`	`}`
Original file line number	Diff line number	Diff line change
`@@ -172,7 +172,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {`
`172`	`172`	`self.end_exclusive`
`173`	`173`	`}`
`174`	`174`
`175`		`- /// Returns the exclusive end page address.`
	`175`	`+ /// Returns the inclusive end page address.`
`176`	`176`	`pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {`
`177`	`177`	`self.end_exclusive.checked_offset(-1).unwrap()`
`178`	`178`	`}`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ impl<ATYPE: AddressType> MemoryRegion<ATYPE> {`
`177`	`177`	`self.end_exclusive`
`178`	`178`	`}`
`179`	`179`
`180`		`- /// Returns the exclusive end page address.`
	`180`	`+ /// Returns the inclusive end page address.`
`181`	`181`	`pub fn end_inclusive_page_addr(&self) -> PageAddress<ATYPE> {`
`182`	`182`	`self.end_exclusive.checked_offset(-1).unwrap()`
`183`	`183`	`}`