RISC-V settings file is not applied when using `svd2rust@0.35.0` and `settings_file`

[jessebraham]

When using svd2rust@0.34.0 and Config.settings, the YAML configuration is loaded from the specified path and applied as expected. Upon updating to svd2rust@0.35.0 and instead using Config.settings_file with the same path, the configuration is no longer applied to the generated PAC.

[burrbull]

Sorry forgot about this. Reading settings file was moved out of render. See

svd2rust/src/lib.rs

Lines 632 to 645 in b6ef0b0

	match config.settings_file.as_ref() {
	#[cfg(feature = "yaml")]
	Some(settings) => {
	let file = std::fs::read_to_string(settings).context("could not read settings file")?;
	config
	.settings
	.update_from(serde_yaml::from_str(&file).context("could not parse settings file")?)
	}
	#[cfg(not(feature = "yaml"))]
	Some(_) => {
	return Err(anyhow::anyhow!("Support for yaml config files is not available because svd2rust was compiled without the yaml feature"));
	}
	None => {}
	};

But as you do not use generate just copy-paste this.

P.S. Config part should be redesigned somehow to better support both cli and lib. But I'm not sure how to better do it.

[romancardenas]

I will try to check this whenever I have some time