Unicode renderer: Use vertical ellipsis rather than double-dagger#337
Open
joshtriplett wants to merge 1 commit intorust-lang:mainfrom
Open
Unicode renderer: Use vertical ellipsis rather than double-dagger#337joshtriplett wants to merge 1 commit intorust-lang:mainfrom
joshtriplett wants to merge 1 commit intorust-lang:mainfrom
Conversation
Contributor
|
Thank you for looking to improve this. Unfortunately, this is a "not yet". The priority is matching rustc's output exactly until annotate-snippets is stable. We then need to figure out what is the process for making changes to the output (colors, shapes, etc). I've been abusing #308 as a place to record thoughts on evolving the output |
Member
Author
|
@epage Fair enough; we should fix this in rustc too, because it's the wrong symbol. :) |
24da1a7 to
daa0d03
Compare
The Unicode renderer used "‡", the double-dagger symbol, to ellipsize the vertical bar to indicate elided lines. Use a vertical ellipsis instead.
daa0d03 to
3882816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unicode renderer used "‡", the double-dagger symbol, to ellipsize
the vertical bar to indicate elided lines.
Use a vertical ellipsis instead.