CI: Run Playwright tests against Svelte app#13373
Closed
Turbo87 wants to merge 3 commits intorust-lang:mainfrom
Closed
CI: Run Playwright tests against Svelte app#13373Turbo87 wants to merge 3 commits intorust-lang:mainfrom
Turbo87 wants to merge 3 commits intorust-lang:mainfrom
Conversation
Turbo87
added
C-internal 🔧
Member
Author
|
Percy is out of snapshots until Saturday... 🙈 on the bright side, the Playwright tests in general are passing already 🎉 |
Turbo87
force-pushed
the
sv-percy-test
branch
2 times, most recently
from
ac6f68f to
d789303
Compare
Turbo87
force-pushed
the
sv-percy-test
branch
2 times, most recently
from
7306eeb to
7fabfa0
Compare
Turbo87
force-pushed
the
sv-percy-test
branch
3 times, most recently
from
0949351 to
ed4b7e9
Compare
Turbo87
force-pushed
the
sv-percy-test
branch
2 times, most recently
from
cce860d to
40ff0cb
Compare
Without this, requests still in flight (or fired by late-running hydration code) bypass the mocks once `worker.disable()` removes the interception and hit the real network instead, surfacing as `[404]` log lines from the SvelteKit `vite preview` web server.
This should allow us to run the Percy visual regression checks against the Svelte app, as a final check whether we have missed anything significant in our porting process.
Calling `worker.disable()` per test sends `Fetch.disable` to the still-alive page, opening a small window in which late-firing hydration requests bypass the mocks and hit the real network. The context is torn down between tests anyway, which removes the MSW route in a single CDP command without that window. Replaces the previous "close pages before disabling MSW" workaround, which prevented the leak on macOS but still left some on Linux CI.
Member
Author
|
closing in favor of #13542 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow us to run the Percy visual regression checks against the Svelte app, as a final check whether we have missed anything significant in our porting process.
Related