svelte: Disable paths.relative for Playwright tests#13521
Merged
Conversation
SvelteKit 2.58.0 (sveltejs/kit#15718) emits root-layout stylesheets in the server HTML to avoid a flash of unstyled content. With `paths.relative: true` (the default), those hrefs are relative to the request URL. Percy preserves the attribute strings verbatim and renders the snapshot at a different URL, so the relative hrefs no longer resolve and the snapshot comes out unstyled. Force absolute paths under `PLAYWRIGHT=1` to keep Percy snapshots stable.
Turbo87
added
the
C-internal 🔧
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SvelteKit 2.58.0 (sveltejs/kit#15718) emits root-layout stylesheets in the server HTML to fix FOUC. With
paths.relative: true(the default), those hrefs are relative to the request URL. Percy preserves the attribute strings verbatim and renders the snapshot at its own URL, so the relative hrefs no longer resolve and the snapshot comes out unstyled.Setting
paths.relative: falseunderPLAYWRIGHT=1keeps Percy snapshots stable. The default applies in production and Vitest builds.Discovered while running #13373.
Related