-
Notifications
You must be signed in to change notification settings - Fork 42
document missing import restrictions #694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tshepang
wants to merge
40
commits into
main
Choose a base branch
from
tshepang/document-use-restrictions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−68
Open
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f96cea0
stray
tshepang 655bbe3
document missing import restrictions
tshepang f18f69d
be more formal
tshepang d02ce01
use normative language
tshepang f69dd3d
make "simple import" definition more clear, and fix one in main text
tshepang 91092bf
use more simple sentences
tshepang 2b56a0b
match existing style
tshepang 9c70941
this fills a prior gap
tshepang 215f85e
clarify rule
tshepang 0f2c9c1
extra precision
tshepang d7e8007
the ranaming applies specifically to the path segment
tshepang 2765077
remove the overspecification
tshepang 857cd5e
re-word to match parent changes
tshepang 29ca7f8
better grammar, maybe
tshepang 542679c
fix case
tshepang c57f5c6
use better terminology
tshepang d6f50e9
there already exists a rule definiting what the 2 keywords mean
tshepang 51e5a8d
this is a special term, so link to definition
tshepang 106dab1
clarity
tshepang 9e87caf
`self` is more special than the other path keywords
tshepang c2ca8e1
unwrap
tshepang a2fd6c1
simplify a rule
tshepang 8724822
move import renaming rules closer together
tshepang 8bc4ab2
update the super import rule
tshepang 001ba74
global path: add a new rule and expand an existing one
tshepang f237bce
consistency
tshepang 9170045
be more precise, and consistent
tshepang 56129b0
use more precise terminology, and removed what is already a separate …
tshepang e3a53f6
use consistent terminology, and flatten list
tshepang 55ab2bc
be more consistent and complete
tshepang e437648
fix grammar and be more precise
tshepang 65a5da6
improve wording
tshepang 90feab2
whitespace
tshepang d261d1c
fix markup
tshepang ed408f7
be more precise, and consistent
tshepang f6cf2fc
much better wording
tshepang 57ceb2f
re-word
tshepang 70947a6
fix rule that is overly broad
tshepang 4332f41
re-word
tshepang 79aefcb
rename "simple path prefix" to "common path prefix"
tshepang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.