Skip to content

Commit 209065b

Browse files
dybuccdybucc
committed
refactor: deprecate *COUNT consts fitting #3131
These constants were already part of prior deprecation efforts in #3620, though this was not completed. Alongside the work and comments there, a few other constants have been researched and marked for deprecation. The accompnying PR contains sources to upstream kernels/libraries with reasoning as to why some constants were deprecated and others weren't.
1 parent 8372b50 commit 209065b

4 files changed

Lines changed: 60 additions & 38 deletions

File tree

‎src/unix/bsd/apple/mod.rs‎

Lines changed: 48 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -3733,7 +3733,11 @@ pub const MNT_NOWAIT: c_int = 2;
37333733

37343734
// <mach/thread_policy.h>
37353735
pub const THREAD_STANDARD_POLICY: c_int = 1;
3736-
pub const THREAD_STANDARD_POLICY_COUNT: c_int = 0;
3736+
3737+
ct! {
3738+
pub const THREAD_STANDARD_POLICY_COUNT: c_int = 0;
3739+
}
3740+
37373741
pub const THREAD_EXTENDED_POLICY: c_int = 1;
37383742
pub const THREAD_TIME_CONSTRAINT_POLICY: c_int = 2;
37393743
pub const THREAD_PRECEDENCE_POLICY: c_int = 3;
@@ -3795,7 +3799,11 @@ pub const VM_PAGE_QUERY_PAGE_CS_NX: i32 = 0x400;
37953799

37963800
// mach/task_info.h
37973801
pub const TASK_THREAD_TIMES_INFO: u32 = 3;
3798-
pub const HOST_CPU_LOAD_INFO_COUNT: u32 = 4;
3802+
3803+
ct! {
3804+
pub const HOST_CPU_LOAD_INFO_COUNT: u32 = 4;
3805+
}
3806+
37993807
pub const MACH_TASK_BASIC_INFO: u32 = 20;
38003808

38013809
pub const MACH_PORT_NULL: i32 = 0;
@@ -3858,7 +3866,10 @@ pub const COPYFILE_STATE_DST_BSIZE: c_int = 12;
38583866
pub const COPYFILE_STATE_BSIZE: c_int = 13;
38593867

38603868
// <sys/attr.h>
3861-
pub const ATTR_BIT_MAP_COUNT: c_ushort = 5;
3869+
ct! {
3870+
pub const ATTR_BIT_MAP_COUNT: c_ushort = 5;
3871+
}
3872+
38623873
pub const FSOPT_NOFOLLOW: u32 = 0x1;
38633874
pub const FSOPT_NOFOLLOW_ANY: u32 = 0x800;
38643875
pub const FSOPT_REPORT_FULLSIZE: u32 = 0x4;
@@ -4029,38 +4040,40 @@ const fn __DARWIN_ALIGN32(p: usize) -> usize {
40294040
(p + __DARWIN_ALIGNBYTES32) & !__DARWIN_ALIGNBYTES32
40304041
}
40314042

4032-
pub const THREAD_EXTENDED_POLICY_COUNT: mach_msg_type_number_t =
4033-
(size_of::<thread_extended_policy_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4034-
pub const THREAD_TIME_CONSTRAINT_POLICY_COUNT: mach_msg_type_number_t =
4035-
(size_of::<thread_time_constraint_policy_data_t>() / size_of::<integer_t>())
4036-
as mach_msg_type_number_t;
4037-
pub const THREAD_PRECEDENCE_POLICY_COUNT: mach_msg_type_number_t =
4038-
(size_of::<thread_precedence_policy_data_t>() / size_of::<integer_t>())
4039-
as mach_msg_type_number_t;
4040-
pub const THREAD_AFFINITY_POLICY_COUNT: mach_msg_type_number_t =
4041-
(size_of::<thread_affinity_policy_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4042-
pub const THREAD_BACKGROUND_POLICY_COUNT: mach_msg_type_number_t =
4043-
(size_of::<thread_background_policy_data_t>() / size_of::<integer_t>())
4044-
as mach_msg_type_number_t;
4045-
pub const THREAD_LATENCY_QOS_POLICY_COUNT: mach_msg_type_number_t =
4046-
(size_of::<thread_latency_qos_policy_data_t>() / size_of::<integer_t>())
4047-
as mach_msg_type_number_t;
4048-
pub const THREAD_THROUGHPUT_QOS_POLICY_COUNT: mach_msg_type_number_t =
4049-
(size_of::<thread_throughput_qos_policy_data_t>() / size_of::<integer_t>())
4050-
as mach_msg_type_number_t;
4051-
pub const THREAD_BASIC_INFO_COUNT: mach_msg_type_number_t =
4052-
(size_of::<thread_basic_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4053-
pub const THREAD_IDENTIFIER_INFO_COUNT: mach_msg_type_number_t =
4054-
(size_of::<thread_identifier_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4055-
pub const THREAD_EXTENDED_INFO_COUNT: mach_msg_type_number_t =
4056-
(size_of::<thread_extended_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4057-
4058-
pub const TASK_THREAD_TIMES_INFO_COUNT: u32 =
4059-
(size_of::<task_thread_times_info_data_t>() / size_of::<natural_t>()) as u32;
4060-
pub const MACH_TASK_BASIC_INFO_COUNT: u32 =
4061-
(size_of::<mach_task_basic_info_data_t>() / size_of::<natural_t>()) as u32;
4062-
pub const HOST_VM_INFO64_COUNT: mach_msg_type_number_t =
4063-
(size_of::<vm_statistics64_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4043+
ct! {
4044+
pub const THREAD_EXTENDED_POLICY_COUNT: mach_msg_type_number_t =
4045+
(size_of::<thread_extended_policy_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4046+
pub const THREAD_TIME_CONSTRAINT_POLICY_COUNT: mach_msg_type_number_t =
4047+
(size_of::<thread_time_constraint_policy_data_t>() / size_of::<integer_t>())
4048+
as mach_msg_type_number_t;
4049+
pub const THREAD_PRECEDENCE_POLICY_COUNT: mach_msg_type_number_t =
4050+
(size_of::<thread_precedence_policy_data_t>() / size_of::<integer_t>())
4051+
as mach_msg_type_number_t;
4052+
pub const THREAD_AFFINITY_POLICY_COUNT: mach_msg_type_number_t =
4053+
(size_of::<thread_affinity_policy_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4054+
pub const THREAD_BACKGROUND_POLICY_COUNT: mach_msg_type_number_t =
4055+
(size_of::<thread_background_policy_data_t>() / size_of::<integer_t>())
4056+
as mach_msg_type_number_t;
4057+
pub const THREAD_LATENCY_QOS_POLICY_COUNT: mach_msg_type_number_t =
4058+
(size_of::<thread_latency_qos_policy_data_t>() / size_of::<integer_t>())
4059+
as mach_msg_type_number_t;
4060+
pub const THREAD_THROUGHPUT_QOS_POLICY_COUNT: mach_msg_type_number_t =
4061+
(size_of::<thread_throughput_qos_policy_data_t>() / size_of::<integer_t>())
4062+
as mach_msg_type_number_t;
4063+
pub const THREAD_BASIC_INFO_COUNT: mach_msg_type_number_t =
4064+
(size_of::<thread_basic_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4065+
pub const THREAD_IDENTIFIER_INFO_COUNT: mach_msg_type_number_t =
4066+
(size_of::<thread_identifier_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4067+
pub const THREAD_EXTENDED_INFO_COUNT: mach_msg_type_number_t =
4068+
(size_of::<thread_extended_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4069+
4070+
pub const TASK_THREAD_TIMES_INFO_COUNT: u32 =
4071+
(size_of::<task_thread_times_info_data_t>() / size_of::<natural_t>()) as u32;
4072+
pub const MACH_TASK_BASIC_INFO_COUNT: u32 =
4073+
(size_of::<mach_task_basic_info_data_t>() / size_of::<natural_t>()) as u32;
4074+
pub const HOST_VM_INFO64_COUNT: mach_msg_type_number_t =
4075+
(size_of::<vm_statistics64_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
4076+
}
40644077

40654078
// bsd/net/if_mib.h
40664079
/// Non-interface-specific

‎src/unix/linux_like/android/mod.rs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1569,7 +1569,10 @@ pub const NFNL_SUBSYS_CTNETLINK_TIMEOUT: c_int = 8;
15691569
pub const NFNL_SUBSYS_CTHELPER: c_int = 9;
15701570
pub const NFNL_SUBSYS_NFTABLES: c_int = 10;
15711571
pub const NFNL_SUBSYS_NFT_COMPAT: c_int = 11;
1572-
pub const NFNL_SUBSYS_COUNT: c_int = 12;
1572+
1573+
ct! {
1574+
pub const NFNL_SUBSYS_COUNT: c_int = 12;
1575+
}
15731576

15741577
pub const NFNL_MSG_BATCH_BEGIN: c_int = NLMSG_MIN_TYPE;
15751578
pub const NFNL_MSG_BATCH_END: c_int = NLMSG_MIN_TYPE + 1;

‎src/unix/linux_like/linux/mod.rs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1899,7 +1899,10 @@ pub const NFNL_SUBSYS_CTHELPER: c_int = 9;
18991899
pub const NFNL_SUBSYS_NFTABLES: c_int = 10;
19001900
pub const NFNL_SUBSYS_NFT_COMPAT: c_int = 11;
19011901
pub const NFNL_SUBSYS_HOOK: c_int = 12;
1902-
pub const NFNL_SUBSYS_COUNT: c_int = 13;
1902+
1903+
ct! {
1904+
pub const NFNL_SUBSYS_COUNT: c_int = 13;
1905+
}
19031906

19041907
pub const NFNL_MSG_BATCH_BEGIN: c_int = crate::NLMSG_MIN_TYPE;
19051908
pub const NFNL_MSG_BATCH_END: c_int = crate::NLMSG_MIN_TYPE + 1;

‎src/unix/solarish/illumos.rs‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,10 @@ pub const PRIV_USER: c_uint = PRIV_DEBUG
186186
| PRIV_AWARE_RESET
187187
| PRIV_PFEXEC;
188188

189-
pub const LGRP_RSRC_COUNT: crate::lgrp_rsrc_t = 2;
189+
ct! {
190+
pub const LGRP_RSRC_COUNT: crate::lgrp_rsrc_t = 2;
191+
}
192+
190193
pub const LGRP_RSRC_CPU: crate::lgrp_rsrc_t = 0;
191194
pub const LGRP_RSRC_MEM: crate::lgrp_rsrc_t = 1;
192195

0 commit comments

Comments
 (0)