Commit 399a0a5
committed
refactor: deprecate
The `off64_t` type may be meant for deprecation, though this may not be
the case after all. This patch targets the fact that we expose such type
in Fuchsia even though that target seems to support definitions from
different standard C library implementations.
For one, the musl library should be left unmodified, as briefly
mentioned in #3248. This patch would be useless if the
only definition that the Fuchsia project sources from is musl's. But
they also vendor the LLVM Libc project, for which we do not have any
exceptions set in place at the time of writing.
Finally, there's the override that the Fuchsia devs have as a
non-vendored dependency over Android Bionic. This seems to add as well
the `off64_t` type. In theory, we should only allow exposing the
bit-suffixed variants in musl and targets using musl.
I am inclined to leave this definition and not deprecate it, as that
would mean prioritizing the definition under the vendores sources of the
Zircon kernel. Still, external input would be appreciated.off64_t type in fuchsia1 parent 2364caf commit 399a0a5
1 file changed
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
41 | 46 | | |
42 | 47 | | |
43 | 48 | | |
| |||
3797 | 3802 | | |
3798 | 3803 | | |
3799 | 3804 | | |
| 3805 | + | |
| 3806 | + | |
| 3807 | + | |
| 3808 | + | |
| 3809 | + | |
3800 | 3810 | | |
3801 | 3811 | | |
3802 | 3812 | | |
| |||
3837 | 3847 | | |
3838 | 3848 | | |
3839 | 3849 | | |
| 3850 | + | |
| 3851 | + | |
| 3852 | + | |
| 3853 | + | |
| 3854 | + | |
3840 | 3855 | | |
3841 | 3856 | | |
3842 | 3857 | | |
| |||
0 commit comments