refactor: deprecate *COUNT consts fitting #3131

These constants were already part of prior deprecation efforts in
#3620, though this was not completed. Alongside the work
and comments there, a few other constants have been researched and
marked for deprecation.

The accompnying PR contains sources to upstream kernels/libraries with
reasoning as to why some constants were deprecated and others weren't.

Author: dybucc

src/unix/bsd/apple/mod.rs

@@ -3733,6 +3733,12 @@ pub const MNT_NOWAIT: c_int = 2;
 
 // <mach/thread_policy.h>
 pub const THREAD_STANDARD_POLICY: c_int = 1;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
 pub const THREAD_STANDARD_POLICY_COUNT: c_int = 0;
 pub const THREAD_EXTENDED_POLICY: c_int = 1;
 pub const THREAD_TIME_CONSTRAINT_POLICY: c_int = 2;
@@ -3795,6 +3801,12 @@ pub const VM_PAGE_QUERY_PAGE_CS_NX: i32 = 0x400;
 
 // mach/task_info.h
 pub const TASK_THREAD_TIMES_INFO: u32 = 3;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
 pub const HOST_CPU_LOAD_INFO_COUNT: u32 = 4;
 pub const MACH_TASK_BASIC_INFO: u32 = 20;
 
@@ -3858,6 +3870,12 @@ pub const COPYFILE_STATE_DST_BSIZE: c_int = 12;
 pub const COPYFILE_STATE_BSIZE: c_int = 13;
 
 // <sys/attr.h>
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
 pub const ATTR_BIT_MAP_COUNT: c_ushort = 5;
 pub const FSOPT_NOFOLLOW: u32 = 0x1;
 pub const FSOPT_NOFOLLOW_ANY: u32 = 0x800;
@@ -4029,38 +4047,120 @@ const fn __DARWIN_ALIGN32(p: usize) -> usize {
     (p + __DARWIN_ALIGNBYTES32) & !__DARWIN_ALIGNBYTES32
 }
 
-pub const THREAD_EXTENDED_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_extended_policy_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
-pub const THREAD_TIME_CONSTRAINT_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_time_constraint_policy_data_t>() / size_of::<integer_t>())
-        as mach_msg_type_number_t;
-pub const THREAD_PRECEDENCE_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_precedence_policy_data_t>() / size_of::<integer_t>())
-        as mach_msg_type_number_t;
-pub const THREAD_AFFINITY_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_affinity_policy_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
-pub const THREAD_BACKGROUND_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_background_policy_data_t>() / size_of::<integer_t>())
-        as mach_msg_type_number_t;
-pub const THREAD_LATENCY_QOS_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_latency_qos_policy_data_t>() / size_of::<integer_t>())
-        as mach_msg_type_number_t;
-pub const THREAD_THROUGHPUT_QOS_POLICY_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_throughput_qos_policy_data_t>() / size_of::<integer_t>())
-        as mach_msg_type_number_t;
-pub const THREAD_BASIC_INFO_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_basic_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
-pub const THREAD_IDENTIFIER_INFO_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_identifier_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
-pub const THREAD_EXTENDED_INFO_COUNT: mach_msg_type_number_t =
-    (size_of::<thread_extended_info_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
-
-pub const TASK_THREAD_TIMES_INFO_COUNT: u32 =
-    (size_of::<task_thread_times_info_data_t>() / size_of::<natural_t>()) as u32;
-pub const MACH_TASK_BASIC_INFO_COUNT: u32 =
-    (size_of::<mach_task_basic_info_data_t>() / size_of::<natural_t>()) as u32;
-pub const HOST_VM_INFO64_COUNT: mach_msg_type_number_t =
-    (size_of::<vm_statistics64_data_t>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_EXTENDED_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_extended_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_TIME_CONSTRAINT_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_time_constraint_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_PRECEDENCE_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_precedence_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_AFFINITY_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_affinity_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_BACKGROUND_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_background_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_LATENCY_QOS_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_latency_qos_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_THROUGHPUT_QOS_POLICY_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_throughput_qos_policy_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_BASIC_INFO_COUNT: mach_msg_type_number_t = (size_of::<thread_basic_info_data_t>()
+    / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_IDENTIFIER_INFO_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_identifier_info_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const THREAD_EXTENDED_INFO_COUNT: mach_msg_type_number_t = (size_of::<
+    thread_extended_info_data_t,
+>() / size_of::<integer_t>()) as mach_msg_type_number_t;
+
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const TASK_THREAD_TIMES_INFO_COUNT: u32 = (size_of::<task_thread_times_info_data_t>()
+    / size_of::<natural_t>()) as u32;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const MACH_TASK_BASIC_INFO_COUNT: u32 = (size_of::<mach_task_basic_info_data_t>()
+    / size_of::<natural_t>()) as u32;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
+pub const HOST_VM_INFO64_COUNT: mach_msg_type_number_t = (size_of::<vm_statistics64_data_t>()
+    / size_of::<integer_t>()) as mach_msg_type_number_t;
 
 // bsd/net/if_mib.h
 /// Non-interface-specific

src/unix/linux_like/android/mod.rs

@@ -1569,6 +1569,12 @@ pub const NFNL_SUBSYS_CTNETLINK_TIMEOUT: c_int = 8;
 pub const NFNL_SUBSYS_CTHELPER: c_int = 9;
 pub const NFNL_SUBSYS_NFTABLES: c_int = 10;
 pub const NFNL_SUBSYS_NFT_COMPAT: c_int = 11;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
 pub const NFNL_SUBSYS_COUNT: c_int = 12;
 
 pub const NFNL_MSG_BATCH_BEGIN: c_int = NLMSG_MIN_TYPE;

src/unix/linux_like/linux/mod.rs

@@ -1899,6 +1899,12 @@ pub const NFNL_SUBSYS_CTHELPER: c_int = 9;
 pub const NFNL_SUBSYS_NFTABLES: c_int = 10;
 pub const NFNL_SUBSYS_NFT_COMPAT: c_int = 11;
 pub const NFNL_SUBSYS_HOOK: c_int = 12;
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
 pub const NFNL_SUBSYS_COUNT: c_int = 13;
 
 pub const NFNL_MSG_BATCH_BEGIN: c_int = crate::NLMSG_MIN_TYPE;

src/unix/solarish/illumos.rs

@@ -186,6 +186,12 @@ pub const PRIV_USER: c_uint = PRIV_DEBUG
     | PRIV_AWARE_RESET
     | PRIV_PFEXEC;
 
+#[deprecated(
+    since = "1.0.0",
+    note = "This constant, among others often used in C for the purposes of denoting the latest \
+            value or limit in a set of constants, has been deprecated. See #3131 for details and \
+            discussion."
+)]
 pub const LGRP_RSRC_COUNT: crate::lgrp_rsrc_t = 2;
 pub const LGRP_RSRC_CPU: crate::lgrp_rsrc_t = 0;
 pub const LGRP_RSRC_MEM: crate::lgrp_rsrc_t = 1;