Add compat module to provide openpty/forkpty on aix#5068
Open
dalvescb wants to merge 1 commit intorust-lang:mainfrom
Open
Add compat module to provide openpty/forkpty on aix#5068dalvescb wants to merge 1 commit intorust-lang:mainfrom
dalvescb wants to merge 1 commit intorust-lang:mainfrom
Conversation
Contributor
|
Thank you for the interest but we don’t want to add more polyfill in this crate. The Solarish versions are planned to be removed when possible #4045. Using one of the wrapper crates like nix or rustix is the correct thing to do if you need functionality that isn’t available on some platforms, so users should already be expecting this from other cases. I believe std also has a polyfill for this as well. Alternatively, the AIX maintainers have been helpful, cc @xingxue-ibm in case this is a planned feature :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I respectfully would like to request allowing this
compatmodule for AIX to be added. There is precedent for this assolarishalso has a module to export the same missing functionsopenptyandforkptyhttps://github.com/rust-lang/libc/blob/088a28455a81c6f9cf770cea42b94380d3cc9b05/src/unix/solarish/compat.rsWithout this module, development on AIX would be significantly hindered.
nixhas its own wrapper foropenpty, but most crates uselibcdirectly. Porting the functionality in another crate likenixwould require having every other crate that useslibcdirectly to switch to thenixAPI, a big ask to simply support a niche OS like AIX. This patch would only affect AIX, and I would be happy to take full responsibility maintaining itSources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI