Skip to content

Commit 642e9e1

Browse files
committed
Remove redundant fallback state in include_references
1 parent d56b49d commit 642e9e1

1 file changed

Lines changed: 0 additions & 11 deletions

File tree

crates/ide-completion/src/completions/postfix.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -410,13 +410,10 @@ fn include_references(initial_element: &ast::Expr) -> (ast::Expr, String) {
410410
let mut resulting_element = initial_element.clone();
411411
let mut prefix = String::new();
412412

413-
let mut found_ref_or_deref = false;
414-
415413
while let Some(parent_deref_element) =
416414
resulting_element.syntax().parent().and_then(ast::PrefixExpr::cast)
417415
&& parent_deref_element.op_kind() == Some(ast::UnaryOp::Deref)
418416
{
419-
found_ref_or_deref = true;
420417
resulting_element = ast::Expr::from(parent_deref_element);
421418

422419
prefix.insert(0, '*');
@@ -425,7 +422,6 @@ fn include_references(initial_element: &ast::Expr) -> (ast::Expr, String) {
425422
while let Some(parent_ref_element) =
426423
resulting_element.syntax().parent().and_then(ast::RefExpr::cast)
427424
{
428-
found_ref_or_deref = true;
429425
let last_child_or_token = parent_ref_element.syntax().last_child_or_token();
430426
prefix.insert_str(
431427
0,
@@ -440,13 +436,6 @@ fn include_references(initial_element: &ast::Expr) -> (ast::Expr, String) {
440436
resulting_element = ast::Expr::from(parent_ref_element);
441437
}
442438

443-
if !found_ref_or_deref {
444-
// If we do not find any ref/deref expressions, restore
445-
// all the progress of tree climbing
446-
prefix.clear();
447-
resulting_element = initial_element.clone();
448-
}
449-
450439
(resulting_element, prefix)
451440
}
452441

0 commit comments

Comments
 (0)