Merge pull request #21963 from ChayimFriedman2/ts-improve

internal: Improve TypeScript code

Author: lnicola

editors/code/package-lock.json

@@ -57,8 +57,8 @@
         "vscode-languageclient": "^9.0.1"
     },
     "devDependencies": {
-        "@eslint/js": "^9.21.0",
-        "@stylistic/eslint-plugin": "^4.1.0",
+        "@eslint/js": "^10.0.1",
+        "@stylistic/eslint-plugin": "^5.10.0",
         "@stylistic/eslint-plugin-js": "^4.1.0",
         "@tsconfig/strictest": "^2.0.5",
         "@types/lodash": "^4.17.20",
@@ -69,14 +69,14 @@
         "@vscode/test-electron": "^2.4.1",
         "@vscode/vsce": "^3.7.1",
         "esbuild": "^0.25.0",
-        "eslint": "^9.21.0",
-        "eslint-config-prettier": "^10.0.2",
+        "eslint": "^10.2.0",
+        "eslint-config-prettier": "^10.1.8",
         "eslint-define-config": "^2.1.0",
         "ovsx": "0.10.10",
-        "prettier": "^3.5.2",
+        "prettier": "^3.8.1",
         "tslib": "^2.8.1",
-        "typescript": "^5.7.3",
-        "typescript-eslint": "^8.25.0"
+        "typescript": "^6.0.2",
+        "typescript-eslint": "^8.58.0"
     },
     "activationEvents": [
         "workspaceContains:Cargo.toml",

editors/code/package.json

@@ -1,4 +1,4 @@
-import * as anser from "anser";
+import anser from "anser";
 import * as lc from "vscode-languageclient/node";
 import * as vscode from "vscode";
 import * as ra from "../src/lsp_ext";

editors/code/src/client.ts

@@ -1194,9 +1194,8 @@ export function runSingle(ctx: CtxInit): Cmd {
 }
 
 export function copyRunCommandLine(ctx: CtxInit) {
-    let prevRunnable: RunnableQuickPick | undefined;
     return async () => {
-        const item = await selectRunnable(ctx, prevRunnable);
+        const item = await selectRunnable(ctx, undefined);
         if (!item || !isCargoRunnableArgs(item.runnable.args)) return;
         const args = createCargoArgs(item.runnable.args);
         const commandLine = ["cargo", ...args].join(" ");

editors/code/src/commands.ts

@@ -485,7 +485,7 @@ export function substituteVariablesInEnv(env: Env): Env {
         Object.entries(env).map(([key, value]) => {
             const deps = new Set<string>();
             if (value) {
-                let match = undefined;
+                let match;
                 while ((match = depRe.exec(value))) {
                     const depName = unwrapUndefinable(match.groups?.["depName"]);
                     deps.add(depName);

editors/code/src/config.ts

@@ -48,7 +48,7 @@ export async function makeDebugConfig(ctx: Ctx, runnable: ra.Runnable): Promise<
 }
 
 export async function startDebugSession(ctx: Ctx, runnable: ra.Runnable): Promise<boolean> {
-    let debugConfig: vscode.DebugConfiguration | undefined = undefined;
+    let debugConfig: vscode.DebugConfiguration | undefined;
     let message = "";
 
     const wsLaunchSection = vscode.workspace.getConfiguration("launch");

editors/code/src/debug.ts

@@ -6,9 +6,9 @@ import * as ra from "./lsp_ext";
 import type { FetchDependencyListResult } from "./lsp_ext";
 import { unwrapUndefinable } from "./util";
 
-export class RustDependenciesProvider
-    implements vscode.TreeDataProvider<Dependency | DependencyFile>
-{
+export class RustDependenciesProvider implements vscode.TreeDataProvider<
+    Dependency | DependencyFile
+> {
     dependenciesMap: { [id: string]: Dependency | DependencyFile };
     ctx: CtxInit;
 

editors/code/src/dependencies_provider.ts

@@ -1,4 +1,4 @@
-import * as anser from "anser";
+import anser from "anser";
 import * as vscode from "vscode";
 import {
     type ProviderResult,

editors/code/src/diagnostics.ts

@@ -100,7 +100,7 @@ export class Cargo {
             );
         } catch (err) {
             log.error(`Cargo invocation has failed: ${err}`);
-            throw new Error(`Cargo invocation has failed: ${err}`);
+            throw new Error(`Cargo invocation has failed: ${err}`, { cause: err });
         }
 
         return spec.filter?.(artifacts) ?? artifacts;

editors/code/src/toolchain.ts

@@ -1,7 +1,6 @@
 {
     "extends": "@tsconfig/strictest/tsconfig.json",
     "compilerOptions": {
-        "esModuleInterop": false,
         "module": "NodeNext",
         "moduleResolution": "nodenext",
         "target": "ES2024",