Skip to content

Commit e9a65f9

Browse files
Apply suggestions from code review
Co-authored-by: Chayim Refael Friedman <chayimfr@gmail.com>
1 parent 793d543 commit e9a65f9

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

crates/hir-ty/src/infer/expr.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1186,13 +1186,7 @@ impl<'db> InferenceContext<'_, 'db> {
11861186
{
11871187
debug!(?remaining_fields);
11881188

1189-
let missing_fields = variant_fields
1190-
.fields()
1191-
.iter()
1192-
.filter_map(|(field_idx, field)| {
1193-
remaining_fields.contains_key(&field.name).then_some(field_idx)
1194-
})
1195-
.collect::<Vec<_>>();
1189+
let missing_fields = remaining_fields.values().copied().collect();
11961190
if !missing_fields.is_empty() {
11971191
self.push_diagnostic(InferenceDiagnostic::MissingFields {
11981192
expr,

crates/hir/src/diagnostics.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -803,6 +803,7 @@ impl<'db> AnyDiagnostic<'db> {
803803
let root = record.file_syntax(db);
804804
let Either::Left(ast::Expr::RecordExpr(record_expr)) = record.value.to_node(&root)
805805
else {
806+
never!("should always map to a `ast::RecordExpr`");
806807
return None;
807808
};
808809

0 commit comments

Comments
 (0)