feat: Allow crate authors to declare that their trait prefers to be imported as _#21740
Open
ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
Open
feat: Allow crate authors to declare that their trait prefers to be imported as _#21740ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
as _#21740ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
commented
Mar 4, 2026
| @@ -1,5 +1,5 @@ | |||
| <!--- | |||
| lsp/ext.rs hash: 235f56089da3dbb5 | |||
Contributor
Author
There was a problem hiding this comment.
This file didn't contain info about CompletionImport at all, so I just updated the hash.
Contributor
Author
|
Can this be reviewed please? I'd like to use this for the solver's trait. |
This comment has been minimized.
This comment has been minimized.
…d `as _` For example for extension traits. Provide an attribute for that. It'll affect flyimport and the autoimport quickfix, as explained in the code.
ChayimFriedman2
force-pushed
the
prefer-underscore-import
branch
from
484e8b2 to
beda061
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example for extension traits.
Provide an attribute for that. It'll affect flyimport and the autoimport quickfix, as explained in the code.
The origin of this is me being angry at the next solver traits that have names identical to the types and make autoimport a nightmare, especially in completion. Then in general we don't do a good job for traits that would be better of imported
as _, I at least leave them imported normally because it's more convenient for flyimport. So this fixes that.