Skip to content

changes to build scripts and config.toml should always refresh #21969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Veykril merged 1 commit into from
Apr 9, 2026
+10 −4
Merged

changes to build scripts and config.toml should always refresh #21969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions crates/rust-analyzer/src/reload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,6 +975,7 @@ pub(crate) fn should_refresh_for_change(
change_kind: ChangeKind,
additional_paths: &[&str],
) -> bool {
// Note: build scripts are retriggered on file save, no refresh is necessary
const IMPLICIT_TARGET_FILES: &[&str] = &["build.rs", "src/main.rs", "src/lib.rs"];
const IMPLICIT_TARGET_DIRS: &[&str] = &["src/bin", "examples", "tests", "benches"];

Expand All @@ -991,15 +992,20 @@ pub(crate) fn should_refresh_for_change(
return true;
}

// .cargo/config{.toml}
if matches!(file_name, "config.toml" | "config")
&& path.parent().map(|parent| parent.as_str().ends_with(".cargo")).unwrap_or(false)
{
return true;
}

// Everything below only matters when files are created or deleted
if change_kind == ChangeKind::Modify {
return false;
}

// .cargo/config{.toml}
if path.extension().unwrap_or_default() != "rs" {
let is_cargo_config = matches!(file_name, "config.toml" | "config")
&& path.parent().map(|parent| parent.as_str().ends_with(".cargo")).unwrap_or(false);
return is_cargo_config;
return false;
}

if IMPLICIT_TARGET_FILES.iter().any(|it| path.as_str().ends_with(it)) {
Expand Down