fix: Check coercion, not unification, in "Fill struct fields", as the criteria to use an existing local as the field's value#21971
Merged
Veykril merged 1 commit intorust-lang:masterfrom Apr 9, 2026
Conversation
rustbot
added
the
S-waiting-on-review
…eria to use an existing local as the field's value Since struct literals allow coercions.
ChayimFriedman2
force-pushed
the
fill-fields-coerce
branch
from
5367076 to
3dcfde9
Compare
Veykril
approved these changes
Apr 9, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since struct literals allow coercions.
Fixes #21932.