feat: add diagnostic for E0784#22202
Open
WeiTheShinobi wants to merge 1 commit intorust-lang:masterfrom
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
rustbot
added
the
S-waiting-on-review
ada4a
reviewed
Apr 28, 2026
| @@ -0,0 +1,42 @@ | |||
| use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext}; | |||
|
|
|||
| // Diagnostic: union-must-have-exactly-one-field | |||
Contributor
There was a problem hiding this comment.
not sure how much this matters, and it would make the already long name even longer, but imo this would be more correct?
Suggested change
| // Diagnostic: union-must-have-exactly-one-field | |
| // Diagnostic: union-expr-must-have-exactly-one-field |
Contributor
There was a problem hiding this comment.
Yeah, I'd prefer that. Same for the variant in InferenceDiagnostic.
ChayimFriedman2
requested changes
Apr 28, 2026
| @@ -0,0 +1,42 @@ | |||
| use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext}; | |||
|
|
|||
| // Diagnostic: union-must-have-exactly-one-field | |||
Contributor
There was a problem hiding this comment.
Yeah, I'd prefer that. Same for the variant in InferenceDiagnostic.
Collaborator
|
☔ The latest upstream changes (possibly #22197) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #22140