fix: improve fn_param adds comma location#22390
Open
A4-Tacks wants to merge 2 commits into
Open
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
force-pushed
the
fn-param-comma-edit
branch
from
4693583 to
9eb0850
Compare
Example
---
```rust
fn bar(file_id: usize) {}
fn baz(
foo: ()
file$0
) {}
```
**Before this PR**
```rust
fn bar(file_id: usize) {}
fn baz(
foo: ()
, file_id: usize
) {}
```
**After this PR**
```rust
fn bar(file_id: usize) {}
fn baz(
foo: (),
file_id: usize,
) {}
```
A4-Tacks
force-pushed
the
fn-param-comma-edit
branch
from
9eb0850 to
fe6fdb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example
Before this PR
After this PR
Before this PR
After this PR