Skip to content

Cleanup bidirection proc-macro-srv protocol a bit#22420

Open
Veykril wants to merge 1 commit into
rust-lang:masterfrom
Veykril:veykril/push-vpqmplstnrxx
Open

Cleanup bidirection proc-macro-srv protocol a bit#22420
Veykril wants to merge 1 commit into
rust-lang:masterfrom
Veykril:veykril/push-vpqmplstnrxx

Conversation

@Veykril
Copy link
Copy Markdown
Member

@Veykril Veykril commented May 22, 2026

Some drive-by cleanups

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2026
@Veykril Veykril force-pushed the veykril/push-vpqmplstnrxx branch 7 times, most recently from 7acdf96 to 73384cf Compare May 22, 2026 09:16
@Veykril Veykril force-pushed the veykril/push-vpqmplstnrxx branch from 73384cf to f417eba Compare May 22, 2026 09:20
@Veykril Veykril enabled auto-merge May 22, 2026 09:26
@Veykril Veykril added this pull request to the merge queue May 22, 2026
Copy link
Copy Markdown
Member

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 189 to 190
// FIXME: Once we can talk back to the client, implement a "long join" request for anchors
// that differ in [AstId]s as joining those spans requires resolving the AstIds.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed now?

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants