Skip to content

fix(hir-ty): saturate float-to-uint cast in const eval #22430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lnicola merged 1 commit into from
May 23, 2026
+4 −1
Merged

fix(hir-ty): saturate float-to-uint cast in const eval #22430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/hir-ty/src/consteval/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,9 @@ fn floating_point_casts() {
check_number(r#"const GOAL: i8 = (0./0.) as i8"#, 0);
check_number(r#"const GOAL: i8 = (1./0.) as i8"#, 127);
check_number(r#"const GOAL: i8 = (-1./0.) as i8"#, -128);
check_number(r#"const GOAL: u8 = (1./0.) as u8"#, 255);
check_number(r#"const GOAL: u8 = 256.0f32 as u8"#, 255);
check_number(r#"const GOAL: u16 = 1e10f32 as u16"#, 65535);
check_number(r#"const GOAL: i64 = 1e18f64 as f32 as i64"#, 999999984306749440);
}

Expand Down
2 changes: 1 addition & 1 deletion crates/hir-ty/src/mir/eval.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1594,7 +1594,7 @@ impl<'a, 'db: 'a> Evaluator<'a, 'db> {
let max = 1i128 << (dest_bits - 1);
(max - 1, -max)
} else {
(1i128 << dest_bits, 0)
((1i128 << dest_bits) - 1, 0)
};
let value = (value as i128).min(max).max(min);
let result = value.to_le_bytes();
Expand Down