feat(ide-diagnostics): add diagnostics for invalid union patterns (E0784) #22433
Open
dotacow wants to merge 2 commits into
Open
feat(ide-diagnostics): add diagnostics for invalid union patterns (E0784) #22433dotacow wants to merge 2 commits into
dotacow wants to merge 2 commits into
Conversation
AI-assisted:I utilized vscode's IDE assistant Copilot.
AI-assisted: I used an LLM to guide me through the debugging process. all code was reviewed and tested.
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds diagnostics to catch invalid union patterns. The diagnostics trigger when a union pattern contains multiple fields or uses the rest (
..) operator.Why
Addresses part of tracking issue #22140, resolving two
FIXMEcomments incrates/hir-ty/src/infer/pat.rs. Alignsrust-analyzerwithrustcbehavior for error E0784.How
UnionPatMustHaveExactlyOneFieldandUnionPatHasRestvariants inhir-ty::InferenceDiagnostic.crates/hir-ty/src/infer/pat.rsduring pattern inference.crates/hir/src/diagnostics.rs.crates/ide-diagnosticsto outputE0784with the correct text messages.Note for reviewers:
The missing record fields FIXME (
E0027) from the same code block is left for a future PR, as attempting to solve it here would be over-scoping this PR.AI usage was declared on a per commit basis as per the contribution guidelines.