fix: Crash on lowering consts with associated types#22646
Open
Wilfred wants to merge 1 commit into
Open
Conversation
Previously we'd modify TyLoweringContext::store without modifying
TyLoweringContext::def. This causes a crash later when we try to look
up the expresison in the wrong store:
thread 'main' panicked at crates/hir-ty/src/infer/expr.rs:326:
should have `ExpressionStore::expr_only`
Instead, ensure we update both consistently so we can find the
expression.
Add a regression test (based on code originally seen in the bitmaps
crate version 3.2.1).
AI disclosure: Bisected and coded with help from Codex and GPT-5.5.
rustbot
added
the
S-waiting-on-review
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we'd modify TyLoweringContext::store without modifying TyLoweringContext::def. This causes a crash later when we try to look up the expression in the wrong store:
Instead, ensure we update both consistently so we can find the expression.
Add a regression test (based on code originally seen in the bitmaps crate version 3.2.1).
AI disclosure: Bisected and coded with help from Codex and GPT-5.5.