don't lint public exports in unused_import_prefixes

Author: hafihaf123

clippy_lints/src/unused_import_prefixes.rs

@@ -66,6 +66,11 @@ impl LateLintPass<'_> for UnusedImportPrefixes {
             return;
         }
 
+        // Do not lint public exports
+        if cx.tcx.visibility(item.owner_id.def_id).is_public() {
+            return;
+        }
+
         // Only check imports starting with the `crate` keyword
         if use_path.segments.is_empty() || use_path.segments[0].ident.name != kw::Crate {
             return;

tests/ui/unused_import_prefixes.fixed

@@ -12,6 +12,9 @@ mod parent {
         // the `crate::` prefix is needed
         use crate::mod_one::StructOne;
 
+        // don't lint public exports
+        pub use crate::parent::child::deep::ItemC;
+
         use self::deep::{ItemA, ItemB};
         //~^ unused_import_prefixes
 
@@ -23,6 +26,7 @@ mod parent {
             pub struct DeepStruct;
             pub struct ItemA;
             pub struct ItemB;
+            pub struct ItemC;
         }
     }
 }

tests/ui/unused_import_prefixes.rs

@@ -12,6 +12,9 @@ mod parent {
         // the `crate::` prefix is needed
         use crate::mod_one::StructOne;
 
+        // don't lint public exports
+        pub use crate::parent::child::deep::ItemC;
+
         use crate::parent::child::deep::{ItemA, ItemB};
         //~^ unused_import_prefixes
 
@@ -23,6 +26,7 @@ mod parent {
             pub struct DeepStruct;
             pub struct ItemA;
             pub struct ItemB;
+            pub struct ItemC;
         }
     }
 }

tests/ui/unused_import_prefixes.stderr

@@ -8,13 +8,13 @@ LL |         use crate::parent::child::deep::DeepStruct;
    = help: to override `-D warnings` add `#[allow(clippy::unused_import_prefixes)]`
 
 error: redundant `crate::...` prefix in an use statement
-  --> tests/ui/unused_import_prefixes.rs:15:13
+  --> tests/ui/unused_import_prefixes.rs:18:13
    |
 LL |         use crate::parent::child::deep::{ItemA, ItemB};
    |             ^^^^^^^^^^^^^^^^^^^^ help: remove redundant use path prefix: `self`
 
 error: redundant `crate::...` prefix in an use statement
-  --> tests/ui/unused_import_prefixes.rs:19:13
+  --> tests/ui/unused_import_prefixes.rs:22:13
    |
 LL |         use crate::parent::child::deep::*;
    |             ^^^^^^^^^^^^^^^^^^^^ help: remove redundant use path prefix: `self`