Attributes cleanup in tests [14/20]

Author: samueltardieu

tests/ui/non_minimal_cfg2.rs

@@ -1,5 +1,4 @@
 //@require-annotations-for-level: WARN
-#![allow(unused)]
 
 #[cfg(all())]
 //~^ ERROR: unneeded sub `cfg` when there is no condition

tests/ui/non_minimal_cfg2.stderr

@@ -1,5 +1,5 @@
 error: unneeded sub `cfg` when there is no condition
-  --> tests/ui/non_minimal_cfg2.rs:4:7
+  --> tests/ui/non_minimal_cfg2.rs:3:7
    |
 LL | #[cfg(all())]
    |       ^^^^^

tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.fixed

@@ -2,7 +2,7 @@
 //@aux-build:lazy_static.rs
 
 #![warn(clippy::non_std_lazy_statics)]
-#![allow(static_mut_refs)]
+#![expect(static_mut_refs)]
 
 use once_cell::sync::Lazy;
 

tests/ui/non_std_lazy_static/non_std_lazy_static_fixable.rs

@@ -2,7 +2,7 @@
 //@aux-build:lazy_static.rs
 
 #![warn(clippy::non_std_lazy_statics)]
-#![allow(static_mut_refs)]
+#![expect(static_mut_refs)]
 
 use once_cell::sync::Lazy;
 

tests/ui/non_std_lazy_static/non_std_lazy_static_unfixable.rs

@@ -3,7 +3,7 @@
 //@no-rustfix
 
 #![warn(clippy::non_std_lazy_statics)]
-#![allow(static_mut_refs)]
+#![expect(static_mut_refs)]
 
 mod once_cell_lazy {
     use once_cell::sync::Lazy;

tests/ui/nonminimal_bool.rs

@@ -1,11 +1,10 @@
 //@no-rustfix: overlapping suggestions
-#![allow(
-    unused,
+#![warn(clippy::nonminimal_bool)]
+#![expect(
     clippy::diverging_sub_expression,
     clippy::needless_ifs,
     clippy::redundant_pattern_matching
 )]
-#![warn(clippy::nonminimal_bool)]
 #![allow(clippy::useless_vec)]
 
 fn main() {

tests/ui/nonminimal_bool.stderr

@@ -1,5 +1,5 @@
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:17:13
+  --> tests/ui/nonminimal_bool.rs:16:13
    |
 LL |     let _ = !true;
    |             ^^^^^
@@ -13,7 +13,7 @@ LL +     let _ = false;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:20:13
+  --> tests/ui/nonminimal_bool.rs:19:13
    |
 LL |     let _ = !false;
    |             ^^^^^^
@@ -25,7 +25,7 @@ LL +     let _ = true;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:23:13
+  --> tests/ui/nonminimal_bool.rs:22:13
    |
 LL |     let _ = !!a;
    |             ^^^
@@ -37,7 +37,7 @@ LL +     let _ = a;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:26:13
+  --> tests/ui/nonminimal_bool.rs:25:13
    |
 LL |     let _ = false || a;
    |             ^^^^^^^^^^
@@ -49,7 +49,7 @@ LL +     let _ = a;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:32:13
+  --> tests/ui/nonminimal_bool.rs:31:13
    |
 LL |     let _ = !(!a && b);
    |             ^^^^^^^^^^
@@ -61,7 +61,7 @@ LL +     let _ = a || !b;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:35:13
+  --> tests/ui/nonminimal_bool.rs:34:13
    |
 LL |     let _ = !(!a || b);
    |             ^^^^^^^^^^
@@ -73,7 +73,7 @@ LL +     let _ = a && !b;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:38:13
+  --> tests/ui/nonminimal_bool.rs:37:13
    |
 LL |     let _ = !a && !(b && c);
    |             ^^^^^^^^^^^^^^^
@@ -85,7 +85,7 @@ LL +     let _ = !(a || b && c);
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:47:13
+  --> tests/ui/nonminimal_bool.rs:46:13
    |
 LL |     let _ = a == b && c == 5 && a == b;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -100,7 +100,7 @@ LL +     let _ = a == b && c == 5;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:50:13
+  --> tests/ui/nonminimal_bool.rs:49:13
    |
 LL |     let _ = a == b || c == 5 || a == b;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -115,7 +115,7 @@ LL +     let _ = a == b || c == 5;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:53:13
+  --> tests/ui/nonminimal_bool.rs:52:13
    |
 LL |     let _ = a == b && c == 5 && b == a;
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -130,7 +130,7 @@ LL +     let _ = a == b && c == 5;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:56:13
+  --> tests/ui/nonminimal_bool.rs:55:13
    |
 LL |     let _ = a != b || !(a != b || c == d);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -145,7 +145,7 @@ LL +     let _ = a != b || c != d;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:59:13
+  --> tests/ui/nonminimal_bool.rs:58:13
    |
 LL |     let _ = a != b && !(a != b && c == d);
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -160,7 +160,7 @@ LL +     let _ = a != b && c != d;
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:90:8
+  --> tests/ui/nonminimal_bool.rs:89:8
    |
 LL |     if matches!(true, true) && true {
    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -172,37 +172,37 @@ LL +     if matches!(true, true) {
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:171:8
+  --> tests/ui/nonminimal_bool.rs:170:8
    |
 LL |     if !(12 == a) {}
    |        ^^^^^^^^^^ help: try: `(12 != a)`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:173:8
+  --> tests/ui/nonminimal_bool.rs:172:8
    |
 LL |     if !(a == 12) {}
    |        ^^^^^^^^^^ help: try: `(a != 12)`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:175:8
+  --> tests/ui/nonminimal_bool.rs:174:8
    |
 LL |     if !(12 != a) {}
    |        ^^^^^^^^^^ help: try: `(12 == a)`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:177:8
+  --> tests/ui/nonminimal_bool.rs:176:8
    |
 LL |     if !(a != 12) {}
    |        ^^^^^^^^^^ help: try: `(a == 12)`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:182:8
+  --> tests/ui/nonminimal_bool.rs:181:8
    |
 LL |     if !b == true {}
    |        ^^^^^^^^^^ help: try: `b != true`
 
 error: equality checks against true are unnecessary
-  --> tests/ui/nonminimal_bool.rs:182:8
+  --> tests/ui/nonminimal_bool.rs:181:8
    |
 LL |     if !b == true {}
    |        ^^^^^^^^^^ help: try: `!b`
@@ -211,55 +211,55 @@ LL |     if !b == true {}
    = help: to override `-D warnings` add `#[allow(clippy::bool_comparison)]`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:185:8
+  --> tests/ui/nonminimal_bool.rs:184:8
    |
 LL |     if !b != true {}
    |        ^^^^^^^^^^ help: try: `b == true`
 
 error: inequality checks against true can be replaced by a negation
-  --> tests/ui/nonminimal_bool.rs:185:8
+  --> tests/ui/nonminimal_bool.rs:184:8
    |
 LL |     if !b != true {}
    |        ^^^^^^^^^^ help: try: `b`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:188:8
+  --> tests/ui/nonminimal_bool.rs:187:8
    |
 LL |     if true == !b {}
    |        ^^^^^^^^^^ help: try: `true != b`
 
 error: equality checks against true are unnecessary
-  --> tests/ui/nonminimal_bool.rs:188:8
+  --> tests/ui/nonminimal_bool.rs:187:8
    |
 LL |     if true == !b {}
    |        ^^^^^^^^^^ help: try: `!b`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:191:8
+  --> tests/ui/nonminimal_bool.rs:190:8
    |
 LL |     if true != !b {}
    |        ^^^^^^^^^^ help: try: `true == b`
 
 error: inequality checks against true can be replaced by a negation
-  --> tests/ui/nonminimal_bool.rs:191:8
+  --> tests/ui/nonminimal_bool.rs:190:8
    |
 LL |     if true != !b {}
    |        ^^^^^^^^^^ help: try: `b`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:194:8
+  --> tests/ui/nonminimal_bool.rs:193:8
    |
 LL |     if !b == !c {}
    |        ^^^^^^^^ help: try: `b == c`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:196:8
+  --> tests/ui/nonminimal_bool.rs:195:8
    |
 LL |     if !b != !c {}
    |        ^^^^^^^^ help: try: `b != c`
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:212:8
+  --> tests/ui/nonminimal_bool.rs:211:8
    |
 LL |     if !(a < 2.0 && !b) {
    |        ^^^^^^^^^^^^^^^^
@@ -271,7 +271,7 @@ LL +     if a >= 2.0 || b {
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:231:12
+  --> tests/ui/nonminimal_bool.rs:230:12
    |
 LL |         if !(matches!(ty, TyKind::Ref(_, _, _)) && !is_mutable(&expr)) {
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -283,13 +283,13 @@ LL +         if !matches!(ty, TyKind::Ref(_, _, _)) || is_mutable(&expr) {
    |
 
 error: this boolean expression can be simplified
-  --> tests/ui/nonminimal_bool.rs:251:8
+  --> tests/ui/nonminimal_bool.rs:250:8
    |
 LL |     if !S != true {}
    |        ^^^^^^^^^^ help: try: `S == true`
 
 error: inequality checks against true can be replaced by a negation
-  --> tests/ui/nonminimal_bool.rs:251:8
+  --> tests/ui/nonminimal_bool.rs:250:8
    |
 LL |     if !S != true {}
    |        ^^^^^^^^^^ help: try: `!!S`

tests/ui/nonminimal_bool_methods.fixed

@@ -1,5 +1,5 @@
-#![allow(unused, clippy::diverging_sub_expression, clippy::needless_ifs)]
 #![warn(clippy::nonminimal_bool)]
+#![expect(clippy::diverging_sub_expression, clippy::needless_ifs)]
 
 fn methods_with_negation() {
     let a: Option<i32> = unimplemented!();

tests/ui/nonminimal_bool_methods.rs

@@ -1,5 +1,5 @@
-#![allow(unused, clippy::diverging_sub_expression, clippy::needless_ifs)]
 #![warn(clippy::nonminimal_bool)]
+#![expect(clippy::diverging_sub_expression, clippy::needless_ifs)]
 
 fn methods_with_negation() {
     let a: Option<i32> = unimplemented!();

tests/ui/obfuscated_if_else.fixed

@@ -1,7 +1,7 @@
 #![warn(clippy::obfuscated_if_else)]
 #![allow(
-    clippy::unnecessary_lazy_evaluations,
     clippy::unit_arg,
+    clippy::unnecessary_lazy_evaluations,
     clippy::unused_unit,
     clippy::unwrap_or_default
 )]