Attributes cleanup in tests [09/20]

Author: samueltardieu

tests/ui/items_after_test_module/imported_module.rs

@@ -1,6 +1,5 @@
 //@ check-pass
 //@compile-flags: --test
-#![allow(unused)]
 #![warn(clippy::items_after_test_module)]
 
 // Nothing here should lint, as `tests` is an imported module (that has no body).

tests/ui/iter_cloned_collect.fixed

@@ -1,5 +1,4 @@
-#![allow(unused)]
-#![allow(clippy::useless_vec)]
+#![expect(clippy::useless_vec)]
 
 use std::collections::{HashSet, VecDeque};
 

tests/ui/iter_cloned_collect.rs

@@ -1,5 +1,4 @@
-#![allow(unused)]
-#![allow(clippy::useless_vec)]
+#![expect(clippy::useless_vec)]
 
 use std::collections::{HashSet, VecDeque};
 

tests/ui/iter_cloned_collect.stderr

@@ -1,5 +1,5 @@
 error: called `.iter().cloned().collect()` on a slice to create a `Vec`
-  --> tests/ui/iter_cloned_collect.rs:8:27
+  --> tests/ui/iter_cloned_collect.rs:7:27
    |
 LL |     let v2: Vec<isize> = v.iter().cloned().collect();
    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -13,7 +13,7 @@ LL +     let v2: Vec<isize> = v.to_vec();
    |
 
 error: called `.iter().cloned().collect()` on a slice to create a `Vec`
-  --> tests/ui/iter_cloned_collect.rs:14:38
+  --> tests/ui/iter_cloned_collect.rs:13:38
    |
 LL |     let _: Vec<isize> = vec![1, 2, 3].iter().cloned().collect();
    |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -25,7 +25,7 @@ LL +     let _: Vec<isize> = vec![1, 2, 3].to_vec();
    |
 
 error: called `.iter().cloned().collect()` on a slice to create a `Vec`
-  --> tests/ui/iter_cloned_collect.rs:20:24
+  --> tests/ui/iter_cloned_collect.rs:19:24
    |
 LL |               .to_bytes()
    |  ________________________^
@@ -46,7 +46,7 @@ LL +             .to_bytes().to_vec();
    |
 
 error: called `.iter().cloned().collect()` on a slice to create a `Vec`
-  --> tests/ui/iter_cloned_collect.rs:29:24
+  --> tests/ui/iter_cloned_collect.rs:28:24
    |
 LL |     let _: Vec<_> = arr.iter().cloned().collect();
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -58,7 +58,7 @@ LL +     let _: Vec<_> = arr.to_vec();
    |
 
 error: called `.iter().copied().collect()` on a slice to create a `Vec`
-  --> tests/ui/iter_cloned_collect.rs:33:26
+  --> tests/ui/iter_cloned_collect.rs:32:26
    |
 LL |     let _: Vec<isize> = v.iter().copied().collect();
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -70,7 +70,7 @@ LL +     let _: Vec<isize> = v.to_vec();
    |
 
 error: called `.iter().cloned().collect()` on a slice to create a `Vec`
-  --> tests/ui/iter_cloned_collect.rs:59:33
+  --> tests/ui/iter_cloned_collect.rs:58:33
    |
 LL |         let v: Vec<&&String> = a.iter().cloned().collect();
    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^

tests/ui/iter_count.fixed

@@ -1,14 +1,8 @@
 //@aux-build:option_helpers.rs
 
 #![warn(clippy::iter_count)]
-#![allow(
-    unused_variables,
-    array_into_iter,
-    unused_mut,
-    clippy::into_iter_on_ref,
-    clippy::unnecessary_operation,
-    clippy::useless_vec
-)]
+#![allow(clippy::into_iter_on_ref, clippy::useless_vec)]
+#![expect(clippy::unnecessary_operation)]
 
 extern crate option_helpers;
 
@@ -33,7 +27,6 @@ impl HasIter {
     }
 }
 
-#[allow(unused_must_use)]
 fn main() {
     let mut vec = vec![0, 1, 2, 3];
     let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);

tests/ui/iter_count.rs

@@ -1,14 +1,8 @@
 //@aux-build:option_helpers.rs
 
 #![warn(clippy::iter_count)]
-#![allow(
-    unused_variables,
-    array_into_iter,
-    unused_mut,
-    clippy::into_iter_on_ref,
-    clippy::unnecessary_operation,
-    clippy::useless_vec
-)]
+#![allow(clippy::into_iter_on_ref, clippy::useless_vec)]
+#![expect(clippy::unnecessary_operation)]
 
 extern crate option_helpers;
 
@@ -33,7 +27,6 @@ impl HasIter {
     }
 }
 
-#[allow(unused_must_use)]
 fn main() {
     let mut vec = vec![0, 1, 2, 3];
     let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);

tests/ui/iter_count.stderr

@@ -1,5 +1,5 @@
 error: called `.iter().count()` on a `slice`
-  --> tests/ui/iter_count.rs:54:6
+  --> tests/ui/iter_count.rs:47:6
    |
 LL |     &vec[..].iter().count();
    |      ^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec[..].len()`
@@ -8,145 +8,145 @@ LL |     &vec[..].iter().count();
    = help: to override `-D warnings` add `#[allow(clippy::iter_count)]`
 
 error: called `.iter().count()` on a `Vec`
-  --> tests/ui/iter_count.rs:56:5
+  --> tests/ui/iter_count.rs:49:5
    |
 LL |     vec.iter().count();
    |     ^^^^^^^^^^^^^^^^^^ help: try: `vec.len()`
 
 error: called `.iter().count()` on a `slice`
-  --> tests/ui/iter_count.rs:58:5
+  --> tests/ui/iter_count.rs:51:5
    |
 LL |     boxed_slice.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `boxed_slice.len()`
 
 error: called `.iter().count()` on a `VecDeque`
-  --> tests/ui/iter_count.rs:60:5
+  --> tests/ui/iter_count.rs:53:5
    |
 LL |     vec_deque.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec_deque.len()`
 
 error: called `.iter().count()` on a `HashSet`
-  --> tests/ui/iter_count.rs:62:5
+  --> tests/ui/iter_count.rs:55:5
    |
 LL |     hash_set.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_set.len()`
 
 error: called `.iter().count()` on a `HashMap`
-  --> tests/ui/iter_count.rs:64:5
+  --> tests/ui/iter_count.rs:57:5
    |
 LL |     hash_map.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_map.len()`
 
 error: called `.iter().count()` on a `BTreeMap`
-  --> tests/ui/iter_count.rs:66:5
+  --> tests/ui/iter_count.rs:59:5
    |
 LL |     b_tree_map.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_tree_map.len()`
 
 error: called `.iter().count()` on a `BTreeSet`
-  --> tests/ui/iter_count.rs:68:5
+  --> tests/ui/iter_count.rs:61:5
    |
 LL |     b_tree_set.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_tree_set.len()`
 
 error: called `.iter().count()` on a `LinkedList`
-  --> tests/ui/iter_count.rs:70:5
+  --> tests/ui/iter_count.rs:63:5
    |
 LL |     linked_list.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `linked_list.len()`
 
 error: called `.iter().count()` on a `BinaryHeap`
-  --> tests/ui/iter_count.rs:72:5
+  --> tests/ui/iter_count.rs:65:5
    |
 LL |     binary_heap.iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `binary_heap.len()`
 
 error: called `.iter_mut().count()` on a `Vec`
-  --> tests/ui/iter_count.rs:75:5
+  --> tests/ui/iter_count.rs:68:5
    |
 LL |     vec.iter_mut().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.len()`
 
 error: called `.iter_mut().count()` on a `slice`
-  --> tests/ui/iter_count.rs:77:6
+  --> tests/ui/iter_count.rs:70:6
    |
 LL |     &vec[..].iter_mut().count();
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec[..].len()`
 
 error: called `.iter_mut().count()` on a `VecDeque`
-  --> tests/ui/iter_count.rs:79:5
+  --> tests/ui/iter_count.rs:72:5
    |
 LL |     vec_deque.iter_mut().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec_deque.len()`
 
 error: called `.iter_mut().count()` on a `HashMap`
-  --> tests/ui/iter_count.rs:81:5
+  --> tests/ui/iter_count.rs:74:5
    |
 LL |     hash_map.iter_mut().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_map.len()`
 
 error: called `.iter_mut().count()` on a `BTreeMap`
-  --> tests/ui/iter_count.rs:83:5
+  --> tests/ui/iter_count.rs:76:5
    |
 LL |     b_tree_map.iter_mut().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_tree_map.len()`
 
 error: called `.iter_mut().count()` on a `LinkedList`
-  --> tests/ui/iter_count.rs:85:5
+  --> tests/ui/iter_count.rs:78:5
    |
 LL |     linked_list.iter_mut().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `linked_list.len()`
 
 error: called `.into_iter().count()` on a `slice`
-  --> tests/ui/iter_count.rs:88:6
+  --> tests/ui/iter_count.rs:81:6
    |
 LL |     &vec[..].into_iter().count();
    |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec[..].len()`
 
 error: called `.into_iter().count()` on a `Vec`
-  --> tests/ui/iter_count.rs:90:5
+  --> tests/ui/iter_count.rs:83:5
    |
 LL |     vec.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec.len()`
 
 error: called `.into_iter().count()` on a `VecDeque`
-  --> tests/ui/iter_count.rs:92:5
+  --> tests/ui/iter_count.rs:85:5
    |
 LL |     vec_deque.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `vec_deque.len()`
 
 error: called `.into_iter().count()` on a `HashSet`
-  --> tests/ui/iter_count.rs:94:5
+  --> tests/ui/iter_count.rs:87:5
    |
 LL |     hash_set.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_set.len()`
 
 error: called `.into_iter().count()` on a `HashMap`
-  --> tests/ui/iter_count.rs:96:5
+  --> tests/ui/iter_count.rs:89:5
    |
 LL |     hash_map.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `hash_map.len()`
 
 error: called `.into_iter().count()` on a `BTreeMap`
-  --> tests/ui/iter_count.rs:98:5
+  --> tests/ui/iter_count.rs:91:5
    |
 LL |     b_tree_map.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_tree_map.len()`
 
 error: called `.into_iter().count()` on a `BTreeSet`
-  --> tests/ui/iter_count.rs:100:5
+  --> tests/ui/iter_count.rs:93:5
    |
 LL |     b_tree_set.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `b_tree_set.len()`
 
 error: called `.into_iter().count()` on a `LinkedList`
-  --> tests/ui/iter_count.rs:102:5
+  --> tests/ui/iter_count.rs:95:5
    |
 LL |     linked_list.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `linked_list.len()`
 
 error: called `.into_iter().count()` on a `BinaryHeap`
-  --> tests/ui/iter_count.rs:104:5
+  --> tests/ui/iter_count.rs:97:5
    |
 LL |     binary_heap.into_iter().count();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `binary_heap.len()`

tests/ui/iter_filter_is_ok.fixed

@@ -1,10 +1,6 @@
 #![warn(clippy::iter_filter_is_ok)]
-#![allow(
-    clippy::map_identity,
-    clippy::result_filter_map,
-    clippy::needless_borrow,
-    clippy::redundant_closure
-)]
+#![allow(clippy::needless_borrow, clippy::redundant_closure)]
+#![expect(clippy::map_identity, clippy::result_filter_map)]
 
 fn main() {
     {

tests/ui/iter_filter_is_ok.rs

@@ -1,10 +1,6 @@
 #![warn(clippy::iter_filter_is_ok)]
-#![allow(
-    clippy::map_identity,
-    clippy::result_filter_map,
-    clippy::needless_borrow,
-    clippy::redundant_closure
-)]
+#![allow(clippy::needless_borrow, clippy::redundant_closure)]
+#![expect(clippy::map_identity, clippy::result_filter_map)]
 
 fn main() {
     {