Attributes cleanup in tests

- Remove `allow` attributes for lints covered by the `unused` group in UI tests
- Replace `allow` with `expect` for lints that fire, remove those that don't
- Reorder attribute names inside allow or expect inner attributes

Author: samueltardieu

tests/ui-cargo/multiple_inherent_impl/config_fail/src/main.rs

@@ -1,3 +1,2 @@
-#![allow(dead_code)]
 #![deny(clippy::multiple_inherent_impl)]
 fn main() {}

tests/ui-cargo/multiple_inherent_impl/crate_fail/Cargo.stderr

@@ -15,9 +15,9 @@ note: first implementation here
  9 | | }
    | |_^
 note: the lint level is defined here
-  --> src/main.rs:2:9
+  --> src/main.rs:1:9
    |
- 2 | #![deny(clippy::multiple_inherent_impl)]
+ 1 | #![deny(clippy::multiple_inherent_impl)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: multiple implementations of this structure

tests/ui-cargo/multiple_inherent_impl/crate_fail/src/main.rs

@@ -1,5 +1,5 @@
-#![allow(dead_code)]
 #![deny(clippy::multiple_inherent_impl)]
+#![allow(dead_code)]
 
 struct S;
 struct T;

tests/ui-cargo/multiple_inherent_impl/file_fail/Cargo.stderr

@@ -15,9 +15,9 @@ note: first implementation here
  8 | | }
    | |_^
 note: the lint level is defined here
-  --> src/main.rs:2:9
+  --> src/main.rs:1:9
    |
- 2 | #![deny(clippy::multiple_inherent_impl)]
+ 1 | #![deny(clippy::multiple_inherent_impl)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: multiple implementations of this structure

tests/ui-cargo/multiple_inherent_impl/file_fail/src/main.rs

@@ -1,5 +1,5 @@
-#![allow(dead_code)]
 #![deny(clippy::multiple_inherent_impl)]
+#![allow(dead_code)]
 
 struct S;
 

tests/ui-cargo/multiple_inherent_impl/module_fail/Cargo.stderr

@@ -1,24 +1,119 @@
+error: struct `S` is never constructed
+ --> src/main.rs:3:8
+  |
+3 | struct S;
+  |        ^
+  |
+  = note: `-D dead-code` implied by `-D warnings`
+  = help: to override `-D warnings` add `#[expect(dead_code)]` or `#[allow(dead_code)]`
+
+error: associated function `first` is never used
+ --> src/main.rs:6:8
+  |
+5 | impl S {
+  | ------ associated function in this implementation
+6 |     fn first() {}
+  |        ^^^^^
+
+error: associated function `second` is never used
+  --> src/main.rs:36:8
+   |
+34 | impl c::S {
+   | --------- associated function in this implementation
+35 |     //^ Must NOT trigger
+36 |     fn second() {}
+   |        ^^^^^^
+
+error: associated function `second` is never used
+  --> src/main.rs:14:12
+   |
+12 |     impl S {
+   |     ------ associated function in this implementation
+13 |         //^ Must NOT trigger
+14 |         fn second() {}
+   |            ^^^^^^
+
+error: struct `S` is never constructed
+  --> src/main.rs:19:12
+   |
+19 |     struct S;
+   |            ^
+
+error: associated function `first` is never used
+  --> src/main.rs:22:12
+   |
+21 |     impl S {
+   |     ------ associated function in this implementation
+22 |         fn first() {}
+   |            ^^^^^
+
+error: associated function `second` is never used
+  --> src/main.rs:28:12
+   |
+25 |     impl S {
+   |     ------ associated function in this implementation
+...
+28 |         fn second() {}
+   |            ^^^^^^
+
+error: struct `S` is never constructed
+ --> src/c.rs:1:12
+  |
+1 | pub struct S;
+  |            ^
+
+error: struct `T` is never constructed
+ --> src/c.rs:2:8
+  |
+2 | struct T;
+  |        ^
+
+error: associated function `first` is never used
+ --> src/c.rs:5:8
+  |
+4 | impl S {
+  | ------ associated function in this implementation
+5 |     fn first() {}
+  |        ^^^^^
+
+error: associated function `first` is never used
+ --> src/c.rs:9:8
+  |
+8 | impl T {
+  | ------ associated function in this implementation
+9 |     fn first() {}
+  |        ^^^^^
+
+error: associated function `second` is never used
+  --> src/c.rs:14:8
+   |
+12 | impl T {
+   | ------ associated function in this implementation
+13 |     //^ Must trigger
+14 |     fn second() {}
+   |        ^^^^^^
+
 error: multiple implementations of this structure
-  --> src/main.rs:26:5
+  --> src/main.rs:25:5
    |
-26 | /     impl S {
-27 | |         //^ Must trigger
-28 | |
-29 | |         fn second() {}
-30 | |     }
+25 | /     impl S {
+26 | |         //^ Must trigger
+27 | |
+28 | |         fn second() {}
+29 | |     }
    | |_____^
    |
 note: first implementation here
-  --> src/main.rs:22:5
+  --> src/main.rs:21:5
    |
-22 | /     impl S {
-23 | |         fn first() {}
-24 | |     }
+21 | /     impl S {
+22 | |         fn first() {}
+23 | |     }
    | |_____^
 note: the lint level is defined here
-  --> src/main.rs:2:9
+  --> src/main.rs:1:9
    |
- 2 | #![deny(clippy::multiple_inherent_impl)]
+ 1 | #![deny(clippy::multiple_inherent_impl)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: multiple implementations of this structure
@@ -38,4 +133,4 @@ note: first implementation here
 10 | | }
    | |_^
 
-error: could not compile `module_fail` (bin "module_fail") due to 2 previous errors
+error: could not compile `module_fail` (bin "module_fail") due to 14 previous errors

tests/ui-cargo/multiple_inherent_impl/module_fail/src/main.rs

@@ -1,4 +1,3 @@
-#![allow(dead_code)]
 #![deny(clippy::multiple_inherent_impl)]
 
 struct S;

tests/ui-toml/arbitrary_source_item_ordering/ordering_good.rs

@@ -18,7 +18,6 @@
 //@[bad_conf_6] error-in-other-file:
 //@compile-flags: --test
 
-#![allow(dead_code)]
 #![warn(clippy::arbitrary_source_item_ordering)]
 
 /// This module gets linted before clippy gives up.

tests/ui-toml/arbitrary_source_item_ordering/ordering_good_var_1.rs

@@ -3,7 +3,6 @@
 //@[var_1] rustc-env:CLIPPY_CONF_DIR=tests/ui-toml/arbitrary_source_item_ordering/var_1
 //@check-pass
 
-#![allow(dead_code)]
 #![warn(clippy::arbitrary_source_item_ordering)]
 
 /// This module gets linted before clippy gives up.