Don't trigger let_underscore_future when the type is specified#17247
Open
mistaste wants to merge 1 commit into
Open
Don't trigger let_underscore_future when the type is specified#17247mistaste wants to merge 1 commit into
let_underscore_future when the type is specified#17247mistaste wants to merge 1 commit into
Conversation
`let _: T = future;` already shows intent through the explicit type annotation, so it should not be linted (mirroring `let_underscore_untyped`, which only fires when no type is given).
Collaborator
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @samueltardieu (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
☔ The latest upstream changes (possibly #17213) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16991.
let_underscore_futurefired even when the discarded value had an explicit typeannotation:
Writing the type already shows intent, and the
mem::dropsuggestion is noisierhere. This makes
let_underscore_futurea strict subset oflet_underscore_untypedby only firing when no type is given (matching how
let_underscore_untypeditselfis gated on
local.ty.is_none()).changelog: [
let_underscore_future]: no longer fires when thelet _binding has an explicit type annotation