perf: skip disallowed-profile resolution when the crate has no profile attributes#17277
Closed
xmakro wants to merge 1 commit into
Closed
perf: skip disallowed-profile resolution when the crate has no profile attributes#17277xmakro wants to merge 1 commit into
xmakro wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
…e attributes The disallowed_methods and disallowed_types lints resolved active profiles for every path, method call and type node, walking HIR parents and caching one entry per visited HirId even though almost no crate uses clippy::disallowed_profile attributes. Scan the crate's attribute maps once on first use and skip resolution entirely when no such attribute exists.
xmakro
force-pushed
the
perf/disallowed-profiles-empty-config
branch
from
0776294 to
be5b25d
Compare
Collaborator
|
☔ The latest upstream changes (possibly #17251) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: none