feat(trusted_asref): new lint#17288
Open
niklasf wants to merge 1 commit into
Open
Conversation
Collaborator
|
r? @dswij rustbot has assigned @dswij. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
Lintcheck changes for 0e8af49
This comment will be updated if you push new changes |
fd691fc to
48e97ef
Compare
Contributor
Author
|
Btw. looks like the lintcheck findings from the pinned redox version were already fixed quite a while ago. |
48e97ef to
0b4194e
Compare
0b4194e to
0e8af49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10323.
Example:
may be broken by pathological
AsRefimplementations using interior mutability.While not all such uses are actually unsound (maybe
ffi()does not actually require consistent arguments here, or maybe all possibleAsRefimplementations come from the same crate), the generated warnings should always be actionable and possibly prevent subtle soundness issues in the future.Scanned crates.io and found 85 candidate crates, of which I so far manually confirmed 5/5 to be actually unsound. Intend to review more and individually submit fixes.
changelog: new lint: [
trusted_asref]