feat: Add profile-specific configuration for disallowed methods and t…#17301
Open
Lallapallooza wants to merge 1 commit into
Open
feat: Add profile-specific configuration for disallowed methods and t…#17301Lallapallooza wants to merge 1 commit into
Lallapallooza wants to merge 1 commit into
Conversation
…ypes Add profile-scoped disallow lists for methods and types, wiring the new configuration tables through a shared resolver that can be toggled with #[clippy::disallowed_profile] attributes. - extend clippy_config::Conf to parse [profiles.*] tables with per-profile disallowed-methods and disallowed-types entries through reusable helpers - introduce clippy_utils::disallowed_profiles to resolve #[clippy::disallowed_profile(s)] attributes with caching, diagnostics for bad inputs, and shared symbol registrations - teach DisallowedMethods and DisallowedTypes to honor active profiles, reuse the combined profile set, and annotate diagnostics with the triggering profile name - add UI TOML coverage for per-profile behavior and refresh the unknown-key fixture for the new configuration entries - register the new attributes and symbols so tool attributes remain recognized and pedantic lints stay clean changelog: [disallowed_methods]: allow selecting per-scope disallow lists via [profiles.*] and the clippy::disallowed_profile attribute changelog: [disallowed_types]: allow selecting per-scope disallow lists via [profiles.*] and the clippy::disallowed_profile attribute
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @samueltardieu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Collaborator
|
This lint has been nominated for inclusion. |
Contributor
Author
|
@Jarcho Hi, are there any updates on FCP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add profile-scoped disallow lists for methods and types, wiring the new configuration tables through a shared resolver that can be toggled with #[clippy::disallowed_profile] attributes.
changelog: [disallowed_methods]: allow selecting per-scope disallow lists via [profiles.] and the clippy::disallowed_profile attribute changelog: [disallowed_types]: allow selecting per-scope disallow lists via [profiles.] and the clippy::disallowed_profile attribute