Rollup merge of #150616 - GuillaumeGomez:update-browser-ui-test, r=lolbinarycat

Update `browser-ui-test` version to `0.23.0`

It comes with new features like conditions and an update to `puppeteer`.

Author: JonathanBrouwer

package.json

@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "browser-ui-test": "^0.22.2",
+    "browser-ui-test": "^0.23.0",
     "es-check": "^9.4.4",
     "eslint": "^8.57.1",
     "typescript": "^5.8.3"

tests/rustdoc-gui/anchors.goml

@@ -15,7 +15,7 @@ define-function: (
         assert-css: (".main-heading h1 span", {"color": |main_heading_type_color|})
         assert-css: (
              ".rightside a.src",
-             {"color": |src_link_color|, "text-decoration": "none solid " + |src_link_color|},
+             {"color": |src_link_color|, "text-decoration": "none"},
              ALL,
         )
         compare-elements-css: (
@@ -32,17 +32,17 @@ define-function: (
         move-cursor-to: ".main-heading a.src"
         assert-css: (
              ".main-heading a.src",
-             {"color": |src_link_color|, "text-decoration": "underline solid " + |src_link_color|},
+             {"color": |src_link_color|, "text-decoration": "underline"},
         )
         move-cursor-to: ".impl-items .rightside a.src"
         assert-css: (
              ".impl-items .rightside a.src",
-             {"color": |src_link_color|, "text-decoration": "none solid " + |src_link_color|},
+             {"color": |src_link_color|, "text-decoration": "none"},
         )
         move-cursor-to: ".impl-items a.rightside.src"
         assert-css: (
              ".impl-items a.rightside.src",
-             {"color": |src_link_color|, "text-decoration": "none solid " + |src_link_color|},
+             {"color": |src_link_color|, "text-decoration": "none"},
         )
 
         go-to: "file://" + |DOC_PATH| + "/test_docs/struct.HeavilyDocumentedStruct.html"

tests/rustdoc-gui/links-color.goml

@@ -41,7 +41,7 @@ define-function: (
         move-cursor-to: "dd a[href='long_code_block_link/index.html']"
         assert-css: (
             "dd a[href='long_code_block_link/index.html']",
-            {"text-decoration": "underline solid " + |mod|},
+            {"text-decoration": "underline"},
         )
     },
 )

tests/rustdoc-gui/sidebar-mobile.goml

@@ -49,7 +49,7 @@ assert-property: ("rustdoc-topbar", {"clientHeight": "45"})
 // so the target is not obscured by the topbar.
 click: ".sidebar-menu-toggle"
 click: ".sidebar-elems section .block li > a"
-assert-position: ("#method\.must_use", {"y": 46})
+assert-position: ("#method\.must_use", {"y": 45})
 
 // Check that the bottom-most item on the sidebar menu can be scrolled fully into view.
 click: ".sidebar-menu-toggle"

tests/rustdoc-gui/sidebar-source-code-display.goml

@@ -141,7 +141,7 @@ click: "#sidebar-button"
 wait-for-css: (".src .sidebar > *", {"visibility": "hidden"})
 // We scroll to line 117 to change the scroll position.
 scroll-to: '//*[@id="117"]'
-store-value: (y_offset, "2567")
+store-value: (y_offset, "2568")
 assert-window-property: {"pageYOffset": |y_offset|}
 // Expanding the sidebar...
 click: "#sidebar-button"