Skip to content

Commit 041a81f

Browse files
committed
rdr: elaborate on how EII-s should be included in the public api hash
1 parent 17f9bd3 commit 041a81f

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

compiler/rustc_metadata/src/rmeta/encoder/public_api_hasher.rs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,12 @@ pub(crate) fn hash_crate_root_public_api(
266266
// FIXME do we need this?
267267
hasher.digest(has_default_lib_allocator, hcx);
268268

269-
// FIXME do we need this?
269+
// Changing externally implementable items should cause recompiles in all downstream crates.
270+
// FIXME EiiDecl and EiiImpl contain spans. Should changing the span of these items cause
271+
// recompiles?
272+
// FIXME eii-s are collected in `rustc_metadata::eii::collect`. We should probably stable sort
273+
// that there to make the query result more stable (but sorting might be useless if this
274+
// should be sensitive to span changes)
270275
let _ = externally_implementable_items;
271276
hasher.digest(tcx.externally_implementable_items(LOCAL_CRATE), hcx);
272277

0 commit comments

Comments
 (0)