resolve: Remove Module::as_local

Author: petrochenkov

compiler/rustc_resolve/src/diagnostics.rs

@@ -3291,7 +3291,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
                 }
                 visited.insert(parent_module, false);
                 let mut res = false;
-                if let Some(m) = r.expect_module(parent_module).as_local() {
+                if let Module::Local(m) = r.expect_module(parent_module) {
                     for importer in m.glob_importers.borrow().iter() {
                         if let Some(next_parent_module) = importer.parent_scope.module.opt_def_id()
                         {

compiler/rustc_resolve/src/ident.rs

@@ -1122,7 +1122,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         }
 
         // In extern modules everything is determined from the start.
-        let Some(module) = module.as_local() else {
+        let Module::Local(module) = module else {
             return Err(ControlFlow::Continue(Determined));
         };
 

compiler/rustc_resolve/src/imports.rs

@@ -43,9 +43,9 @@ use crate::errors::{
 use crate::ref_mut::CmCell;
 use crate::{
     AmbiguityError, BindingKey, CmResolver, Decl, DeclData, DeclKind, Determinacy, Finalize,
-    IdentKey, ImportSuggestion, ImportSummary, LocalModule, ModuleOrUniformRoot, ParentScope,
-    PathResult, PerNS, Res, ResolutionError, Resolver, ScopeSet, Segment, Used, module_to_string,
-    names_to_string,
+    IdentKey, ImportSuggestion, ImportSummary, LocalModule, Module, ModuleOrUniformRoot,
+    ParentScope, PathResult, PerNS, Res, ResolutionError, Resolver, ScopeSet, Segment, Used,
+    module_to_string, names_to_string,
 };
 
 /// A potential import declaration in the process of being planted into a module.
@@ -1790,7 +1790,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {
         }
 
         // Add to module's glob_importers
-        if let Some(module) = module.as_local() {
+        if let Module::Local(module) = module {
             module.glob_importers.borrow_mut_unchecked().push(import);
         }
 

compiler/rustc_resolve/src/lib.rs

@@ -827,13 +827,6 @@ impl<'ra> Module<'ra> {
         true
     }
 
-    fn as_local(self) -> Option<LocalModule<'ra>> {
-        match self {
-            Module::Local(m) => Some(m),
-            Module::Extern(_) => None,
-        }
-    }
-
     #[track_caller]
     fn expect_local(self) -> LocalModule<'ra> {
         match self {