Add support for static EIIs in late resolution

Author: JonathanBrouwer

compiler/rustc_resolve/src/late.rs

@@ -530,9 +530,8 @@ impl PathSource<'_, '_, '_> {
                 },
                 _ => "value",
             },
-            PathSource::ReturnTypeNotation
-            | PathSource::Delegation
-            | PathSource::ExternItemImpl => "function",
+            PathSource::ReturnTypeNotation | PathSource::Delegation => "function",
+            PathSource::ExternItemImpl => "function or static",
             PathSource::PreciseCapturingArg(..) => "type or const parameter",
             PathSource::Macro => "macro",
             PathSource::Module => "module",
@@ -625,7 +624,13 @@ impl PathSource<'_, '_, '_> {
             },
             PathSource::Delegation => matches!(res, Res::Def(DefKind::Fn | DefKind::AssocFn, _)),
             PathSource::ExternItemImpl => {
-                matches!(res, Res::Def(DefKind::Fn | DefKind::AssocFn | DefKind::Ctor(..), _))
+                matches!(
+                    res,
+                    Res::Def(
+                        DefKind::Fn | DefKind::AssocFn | DefKind::Ctor(..) | DefKind::Static { .. },
+                        _
+                    )
+                )
             }
             PathSource::PreciseCapturingArg(ValueNS) => {
                 matches!(res, Res::Def(DefKind::ConstParam, _))
@@ -5500,7 +5505,7 @@ impl<'a, 'ast, 'ra, 'tcx> LateResolutionVisitor<'a, 'ast, 'ra, 'tcx> {
                     *node_id,
                     &None,
                     &target.foreign_item,
-                    PathSource::ExternItemImpl
+                    PathSource::ExternItemImpl,
                 );
             } else {
                 self.smart_resolve_path(*node_id, &None, &eii_macro_path, PathSource::Macro);

tests/ui/eii/eii-declaration-not-fn-issue-152337.rs

@@ -6,7 +6,7 @@
 const A: () = ();
 #[eii]
 fn A() {} //~ ERROR the name `A` is defined multiple times
-//~^ ERROR expected function, found constant
-//~| ERROR expected function, found constant
+//~^ ERROR expected function or static, found constant
+//~| ERROR expected function or static, found constant
 
 fn main() {}

tests/ui/eii/eii-declaration-not-fn-issue-152337.stderr

@@ -9,17 +9,17 @@ LL | fn A() {}
    |
    = note: `A` must be defined only once in the value namespace of this module
 
-error[E0423]: expected function, found constant `self::A`
+error[E0423]: expected function or static, found constant `self::A`
   --> $DIR/eii-declaration-not-fn-issue-152337.rs:8:4
    |
 LL | fn A() {}
-   |    ^ not a function
+   |    ^ not a function or static
 
-error[E0423]: expected function, found constant `A`
+error[E0423]: expected function or static, found constant `A`
   --> $DIR/eii-declaration-not-fn-issue-152337.rs:8:4
    |
 LL | fn A() {}
-   |    ^ not a function
+   |    ^ not a function or static
 
 error: aborting due to 3 previous errors
 

tests/ui/eii/static/multiple_decls.rs

@@ -4,6 +4,7 @@ const A: () = ();
 #[eii(A)]
 static A: u64;
 //~^ ERROR the name `A` is defined multiple times
+//~| ERROR expected function or static, found constant `A`
 
 #[A]
 static A_IMPL: u64 = 5;

tests/ui/eii/static/multiple_decls.stderr

@@ -9,6 +9,13 @@ LL | static A: u64;
    |
    = note: `A` must be defined only once in the value namespace of this module
 
-error: aborting due to 1 previous error
+error[E0423]: expected function or static, found constant `A`
+  --> $DIR/multiple_decls.rs:5:8
+   |
+LL | static A: u64;
+   |        ^ not a function or static
+
+error: aborting due to 2 previous errors
 
-For more information about this error, try `rustc --explain E0428`.
+Some errors have detailed explanations: E0423, E0428.
+For more information about an error, try `rustc --explain E0423`.