Migrate rustc_trait_selection to use TyCtxt::emit_diag_node_span_lint

GuillaumeGomez · GuillaumeGomez · commit 1c6c0f73160c · 2026-02-24T20:25:22.000+01:00
diff --git a/compiler/rustc_passes/src/check_attr.rs b/compiler/rustc_passes/src/check_attr.rs
@@ -639,7 +639,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
                         }
                     });
                     if !has_generic {
-                        self.tcx.emit_node_span_lint(
+                        self.tcx.emit_diag_node_span_lint(
                             MALFORMED_DIAGNOSTIC_FORMAT_LITERALS,
                             hir_id,
                             span,
diff --git a/compiler/rustc_passes/src/errors.rs b/compiler/rustc_passes/src/errors.rs
@@ -1450,7 +1450,7 @@ pub(crate) struct FunctionNamesDuplicated {
     pub spans: Vec<Span>,
 }
 
-#[derive(LintDiagnostic)]
+#[derive(Diagnostic)]
 #[diag("there is no parameter `{$argument_name}` on trait `{$trait_name}`")]
 pub(crate) struct UnknownFormatParameterForOnUnimplementedAttr {
     pub argument_name: Symbol,

Original file line number	Diff line number	Diff line change
`@@ -639,7 +639,7 @@ impl<'tcx> CheckAttrVisitor<'tcx> {`
`639`	`639`	`}`
`640`	`640`	`});`
`641`	`641`	`if !has_generic {`
`642`		`- self.tcx.emit_node_span_lint(`
	`642`	`+ self.tcx.emit_diag_node_span_lint(`
`643`	`643`	`MALFORMED_DIAGNOSTIC_FORMAT_LITERALS,`
`644`	`644`	`hir_id,`
`645`	`645`	`span,`
Original file line number	Diff line number	Diff line change
`@@ -1450,7 +1450,7 @@ pub(crate) struct FunctionNamesDuplicated {`
`1450`	`1450`	`pub spans: Vec<Span>,`
`1451`	`1451`	`}`
`1452`	`1452`
`1453`		`-#[derive(LintDiagnostic)]`
	`1453`	`+#[derive(Diagnostic)]`
`1454`	`1454`	#[diag("there is no parameter `{$argument_name}` on trait `{$trait_name}`")]
`1455`	`1455`	`pub(crate) struct UnknownFormatParameterForOnUnimplementedAttr {`
`1456`	`1456`	`pub argument_name: Symbol,`