Rollup merge of #147809 - GuillaumeGomez:fix-rustdoc-passes, r=fmease

rustdoc: Fix passes order so intra-doc links are collected after stripping passes

Fixes regression I introduced in #147153.

This PR puts back the intra-doc link collecting pass after the stripping items pass, preventing lints to be emitted on non-visible items.

Although, might be nice to add a way to change this behaviour. To be discussed later on.

cc ``@ojeda``
r? ``@fmease``

Author: matthiaskrgr

src/librustdoc/passes/mod.rs

@@ -94,11 +94,11 @@ pub(crate) const DEFAULT_PASSES: &[ConditionalPass] = &[
     ConditionalPass::always(COLLECT_TRAIT_IMPLS),
     ConditionalPass::always(CHECK_DOC_TEST_VISIBILITY),
     ConditionalPass::always(CHECK_DOC_CFG),
-    ConditionalPass::always(COLLECT_INTRA_DOC_LINKS),
     ConditionalPass::always(STRIP_ALIASED_NON_LOCAL),
     ConditionalPass::new(STRIP_HIDDEN, WhenNotDocumentHidden),
     ConditionalPass::new(STRIP_PRIVATE, WhenNotDocumentPrivate),
     ConditionalPass::new(STRIP_PRIV_IMPORTS, WhenDocumentPrivate),
+    ConditionalPass::always(COLLECT_INTRA_DOC_LINKS),
     ConditionalPass::always(PROPAGATE_DOC_CFG),
     ConditionalPass::always(PROPAGATE_STABILITY),
     ConditionalPass::always(RUN_LINTS),

tests/rustdoc-ui/intra-doc/hidden-check.rs

@@ -0,0 +1,14 @@
+// This test ensures that `doc(hidden)` items intra-doc links are checked whereas private
+// items are ignored.
+
+//@ compile-flags: -Zunstable-options --document-hidden-items
+
+#![deny(rustdoc::broken_intra_doc_links)]
+
+/// [not::exist]
+//~^ ERROR unresolved link to `not::exist`
+#[doc(hidden)]
+pub struct X;
+
+/// [not::exist]
+struct Y;

tests/rustdoc-ui/intra-doc/hidden-check.stderr

@@ -0,0 +1,14 @@
+error: unresolved link to `not::exist`
+  --> $DIR/hidden-check.rs:8:6
+   |
+LL | /// [not::exist]
+   |      ^^^^^^^^^^ no item named `not` in scope
+   |
+note: the lint level is defined here
+  --> $DIR/hidden-check.rs:6:9
+   |
+LL | #![deny(rustdoc::broken_intra_doc_links)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: aborting due to 1 previous error
+

tests/rustdoc-ui/intra-doc/private-check.rs

@@ -0,0 +1,14 @@
+// This test ensures that private items intra-doc links are checked whereas `doc(hidden)`
+// items are ignored.
+
+//@ compile-flags: -Zunstable-options --document-private-items
+
+#![deny(rustdoc::broken_intra_doc_links)]
+
+/// [not::exist]
+#[doc(hidden)]
+pub struct X;
+
+/// [not::exist]
+//~^ ERROR unresolved link to `not::exist`
+struct Y;

tests/rustdoc-ui/intra-doc/private-check.stderr

@@ -0,0 +1,14 @@
+error: unresolved link to `not::exist`
+  --> $DIR/private-check.rs:12:6
+   |
+LL | /// [not::exist]
+   |      ^^^^^^^^^^ no item named `not` in scope
+   |
+note: the lint level is defined here
+  --> $DIR/private-check.rs:6:9
+   |
+LL | #![deny(rustdoc::broken_intra_doc_links)]
+   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error: aborting due to 1 previous error
+

tests/rustdoc-ui/issues/issue-91713.stdout

@@ -16,11 +16,11 @@ Default passes for rustdoc:
  collect-trait-impls
 check_doc_test_visibility
        check-doc-cfg
-collect-intra-doc-links
 strip-aliased-non-local
         strip-hidden  (when not --document-hidden-items)
        strip-private  (when not --document-private-items)
   strip-priv-imports  (when --document-private-items)
+collect-intra-doc-links
    propagate-doc-cfg
  propagate-stability
            run-lints