Properly check arguments of #[rustc_dump_layout]

Author: JonathanBrouwer

compiler/rustc_attr_parsing/src/attributes/rustc_dump.rs

@@ -110,7 +110,7 @@ impl<S: Stage> CombineAttributeParser<S> for RustcDumpLayoutParser {
 
         let mut result = Vec::new();
         for item in items.mixed() {
-            let Some(arg) = item.meta_item() else {
+            let Some(arg) = item.meta_item_no_args() else {
                 cx.adcx().expected_not_literal(item.span());
                 continue;
             };

tests/ui/attributes/args-checked.rs

@@ -51,4 +51,12 @@ static H: u64 = 5;
 //~^ ERROR malformed
 trait T {
 
+}
+
+#[rustc_dump_layout(debug = 5)]
+//~^ ERROR malformed
+#[rustc_dump_layout(debug(x, y, z))]
+//~^ ERROR malformed
+enum E {
+
 }

tests/ui/attributes/args-checked.stderr

@@ -206,6 +206,22 @@ LL | #[rustc_must_implement_one_of(eq(x, y, z), neq)]
    | |                             expected a valid identifier here
    | help: must be of the form: `#[rustc_must_implement_one_of(function1, function2, ...)]`
 
+error[E0565]: malformed `rustc_dump_layout` attribute input
+  --> $DIR/args-checked.rs:56:1
+   |
+LL | #[rustc_dump_layout(debug = 5)]
+   | ^^^^^^^^^^^^^^^^^^^^---------^^
+   |                     |
+   |                     didn't expect a literal here
+
+error[E0565]: malformed `rustc_dump_layout` attribute input
+  --> $DIR/args-checked.rs:58:1
+   |
+LL | #[rustc_dump_layout(debug(x, y, z))]
+   | ^^^^^^^^^^^^^^^^^^^^--------------^^
+   |                     |
+   |                     didn't expect a literal here
+
 error: valid forms for the attribute are `#[macro_export(local_inner_macros)]` and `#[macro_export]`
   --> $DIR/args-checked.rs:26:1
    |
@@ -225,9 +241,10 @@ LL | #[macro_export(local_inner_macros(x, y, z))]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
    = note: for more information, see issue #57571 <https://github.com/rust-lang/rust/issues/57571>
 
-error: aborting due to 16 previous errors
+error: aborting due to 18 previous errors
 
-For more information about this error, try `rustc --explain E0539`.
+Some errors have detailed explanations: E0539, E0565.
+For more information about an error, try `rustc --explain E0539`.
 Future incompatibility report: Future breakage diagnostic:
 error: valid forms for the attribute are `#[macro_export(local_inner_macros)]` and `#[macro_export]`
   --> $DIR/args-checked.rs:26:1