Add target checking to #[register_tool]

Author: JonathanBrouwer

compiler/rustc_attr_parsing/src/attributes/crate_level.rs

@@ -314,7 +314,7 @@ impl CombineAttributeParser for RegisterToolParser {
     const PATH: &[Symbol] = &[sym::register_tool];
     type Item = Ident;
     const CONVERT: ConvertFn<Self::Item> = |tools, _span| AttributeKind::RegisterTool(tools);
-    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowList(ALL_TARGETS);
+    const ALLOWED_TARGETS: AllowedTargets = AllowedTargets::AllowList(&[Allow(Target::Crate)]);
     const TEMPLATE: AttributeTemplate = template!(List: &["tool1, tool2, ..."]);
     const STABILITY: AttributeStability = unstable!(register_tool);
 

tests/ui/attributes/attr-on-mac-call.rs

@@ -1,6 +1,7 @@
 //@ check-pass
 // Regression test for https://github.com/rust-lang/rust/issues/145779
 #![warn(unused_attributes)]
+#![feature(register_tool)]
 
 fn main() {
     #[export_name = "x"]
@@ -103,4 +104,7 @@ fn main() {
     //~^ WARN attribute cannot be used on macro calls
     //~| WARN previously accepted
     unreachable!();
+    #[register_tool(xyz)]
+    //~^ WARN crate-level attribute should be an inner attribute
+    unreachable!();
 }

tests/ui/attributes/attr-on-mac-call.stderr

@@ -1,5 +1,5 @@
 warning: `#[export_name]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:6:5
+  --> $DIR/attr-on-mac-call.rs:7:5
    |
 LL |     #[export_name = "x"]
    |     ^^^^^^^^^^^^^^^^^^^^
@@ -13,7 +13,7 @@ LL | #![warn(unused_attributes)]
    |         ^^^^^^^^^^^^^^^^^
 
 warning: `#[naked]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:9:5
+  --> $DIR/attr-on-mac-call.rs:10:5
    |
 LL |     #[unsafe(naked)]
    |     ^^^^^^^^^^^^^^^^
@@ -22,7 +22,7 @@ LL |     #[unsafe(naked)]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[track_caller]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:12:5
+  --> $DIR/attr-on-mac-call.rs:13:5
    |
 LL |     #[track_caller]
    |     ^^^^^^^^^^^^^^^
@@ -31,7 +31,7 @@ LL |     #[track_caller]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[used]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:15:5
+  --> $DIR/attr-on-mac-call.rs:16:5
    |
 LL |     #[used]
    |     ^^^^^^^
@@ -40,7 +40,7 @@ LL |     #[used]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[target_feature]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:18:5
+  --> $DIR/attr-on-mac-call.rs:19:5
    |
 LL |     #[target_feature(enable = "x")]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -49,7 +49,7 @@ LL |     #[target_feature(enable = "x")]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[deprecated]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:21:5
+  --> $DIR/attr-on-mac-call.rs:22:5
    |
 LL |     #[deprecated]
    |     ^^^^^^^^^^^^^
@@ -58,7 +58,7 @@ LL |     #[deprecated]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[inline]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:24:5
+  --> $DIR/attr-on-mac-call.rs:25:5
    |
 LL |     #[inline]
    |     ^^^^^^^^^
@@ -67,7 +67,7 @@ LL |     #[inline]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[link_name]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:27:5
+  --> $DIR/attr-on-mac-call.rs:28:5
    |
 LL |     #[link_name = "x"]
    |     ^^^^^^^^^^^^^^^^^^
@@ -76,7 +76,7 @@ LL |     #[link_name = "x"]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[link_section]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:30:5
+  --> $DIR/attr-on-mac-call.rs:31:5
    |
 LL |     #[link_section = "__TEXT,__text"]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@@ -85,7 +85,7 @@ LL |     #[link_section = "__TEXT,__text"]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[link_ordinal]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:33:5
+  --> $DIR/attr-on-mac-call.rs:34:5
    |
 LL |     #[link_ordinal(42)]
    |     ^^^^^^^^^^^^^^^^^^^
@@ -94,7 +94,7 @@ LL |     #[link_ordinal(42)]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[non_exhaustive]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:36:5
+  --> $DIR/attr-on-mac-call.rs:37:5
    |
 LL |     #[non_exhaustive]
    |     ^^^^^^^^^^^^^^^^^
@@ -103,7 +103,7 @@ LL |     #[non_exhaustive]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[proc_macro]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:39:5
+  --> $DIR/attr-on-mac-call.rs:40:5
    |
 LL |     #[proc_macro]
    |     ^^^^^^^^^^^^^
@@ -112,7 +112,7 @@ LL |     #[proc_macro]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[cold]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:42:5
+  --> $DIR/attr-on-mac-call.rs:43:5
    |
 LL |     #[cold]
    |     ^^^^^^^
@@ -121,7 +121,7 @@ LL |     #[cold]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[no_mangle]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:45:5
+  --> $DIR/attr-on-mac-call.rs:46:5
    |
 LL |     #[no_mangle]
    |     ^^^^^^^^^^^^
@@ -130,7 +130,7 @@ LL |     #[no_mangle]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[deprecated]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:48:5
+  --> $DIR/attr-on-mac-call.rs:49:5
    |
 LL |     #[deprecated]
    |     ^^^^^^^^^^^^^
@@ -139,7 +139,7 @@ LL |     #[deprecated]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[automatically_derived]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:51:5
+  --> $DIR/attr-on-mac-call.rs:52:5
    |
 LL |     #[automatically_derived]
    |     ^^^^^^^^^^^^^^^^^^^^^^^^
@@ -148,7 +148,7 @@ LL |     #[automatically_derived]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[macro_use]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:54:5
+  --> $DIR/attr-on-mac-call.rs:55:5
    |
 LL |     #[macro_use]
    |     ^^^^^^^^^^^^
@@ -157,7 +157,7 @@ LL |     #[macro_use]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[must_use]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:57:5
+  --> $DIR/attr-on-mac-call.rs:58:5
    |
 LL |     #[must_use]
    |     ^^^^^^^^^^^
@@ -166,7 +166,7 @@ LL |     #[must_use]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[no_implicit_prelude]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:60:5
+  --> $DIR/attr-on-mac-call.rs:61:5
    |
 LL |     #[no_implicit_prelude]
    |     ^^^^^^^^^^^^^^^^^^^^^^
@@ -175,7 +175,7 @@ LL |     #[no_implicit_prelude]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[path]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:63:5
+  --> $DIR/attr-on-mac-call.rs:64:5
    |
 LL |     #[path = ""]
    |     ^^^^^^^^^^^^
@@ -184,7 +184,7 @@ LL |     #[path = ""]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[ignore]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:66:5
+  --> $DIR/attr-on-mac-call.rs:67:5
    |
 LL |     #[ignore]
    |     ^^^^^^^^^
@@ -193,7 +193,7 @@ LL |     #[ignore]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[should_panic]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:69:5
+  --> $DIR/attr-on-mac-call.rs:70:5
    |
 LL |     #[should_panic]
    |     ^^^^^^^^^^^^^^^
@@ -202,7 +202,7 @@ LL |     #[should_panic]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[link_name]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:72:5
+  --> $DIR/attr-on-mac-call.rs:73:5
    |
 LL |     #[link_name = "x"]
    |     ^^^^^^^^^^^^^^^^^^
@@ -211,7 +211,7 @@ LL |     #[link_name = "x"]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[repr()]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:77:5
+  --> $DIR/attr-on-mac-call.rs:78:5
    |
 LL |     #[repr()]
    |     ^^^^^^^^^
@@ -220,15 +220,15 @@ LL |     #[repr()]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: unused attribute
-  --> $DIR/attr-on-mac-call.rs:77:5
+  --> $DIR/attr-on-mac-call.rs:78:5
    |
 LL |     #[repr()]
    |     ^^^^^^^^^ help: remove this attribute
    |
    = note: using `repr` with an empty list has no effect
 
 warning: `#[repr(u8)]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:82:5
+  --> $DIR/attr-on-mac-call.rs:83:5
    |
 LL |     #[repr(u8)]
    |     ^^^^^^^^^^^
@@ -237,7 +237,7 @@ LL |     #[repr(u8)]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[repr(align(...))]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:86:5
+  --> $DIR/attr-on-mac-call.rs:87:5
    |
 LL |     #[repr(align(8))]
    |     ^^^^^^^^^^^^^^^^^
@@ -246,7 +246,7 @@ LL |     #[repr(align(8))]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[repr(packed)]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:90:5
+  --> $DIR/attr-on-mac-call.rs:91:5
    |
 LL |     #[repr(packed)]
    |     ^^^^^^^^^^^^^^^
@@ -255,7 +255,7 @@ LL |     #[repr(packed)]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[repr(C)]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:94:5
+  --> $DIR/attr-on-mac-call.rs:95:5
    |
 LL |     #[repr(C)]
    |     ^^^^^^^^^^
@@ -264,7 +264,7 @@ LL |     #[repr(C)]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[repr(Rust)]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:98:5
+  --> $DIR/attr-on-mac-call.rs:99:5
    |
 LL |     #[repr(Rust)]
    |     ^^^^^^^^^^^^^
@@ -273,13 +273,25 @@ LL |     #[repr(Rust)]
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
 warning: `#[repr(simd)]` attribute cannot be used on macro calls
-  --> $DIR/attr-on-mac-call.rs:102:5
+  --> $DIR/attr-on-mac-call.rs:103:5
    |
 LL |     #[repr(simd)]
    |     ^^^^^^^^^^^^^
    |
    = help: `#[repr(simd)]` can only be applied to structs
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
 
-warning: 31 warnings emitted
+warning: crate-level attribute should be an inner attribute: add an exclamation mark: `#![register_tool]`
+  --> $DIR/attr-on-mac-call.rs:107:5
+   |
+LL |     #[register_tool(xyz)]
+   |     ^^^^^^^^^^^^^^^^^^^^^
+   |
+note: this attribute does not have an `!`, which means it is applied to this macro call
+  --> $DIR/attr-on-mac-call.rs:109:5
+   |
+LL |     unreachable!();
+   |     ^^^^^^^^^^^^^^
+
+warning: 32 warnings emitted
 

tests/ui/attributes/register-tool-target.rs

@@ -0,0 +1,8 @@
+//@ check-pass
+#![feature(register_tool)]
+
+#[register_tool(no_valid_target)]
+//~^ WARN crate-level attribute should be an inner attribute
+fn main() {
+
+}

tests/ui/attributes/register-tool-target.stderr

@@ -0,0 +1,17 @@
+warning: crate-level attribute should be an inner attribute: add an exclamation mark: `#![register_tool]`
+  --> $DIR/register-tool-target.rs:4:1
+   |
+LL | #[register_tool(no_valid_target)]
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+   |
+note: this attribute does not have an `!`, which means it is applied to this function
+  --> $DIR/register-tool-target.rs:6:1
+   |
+LL | / fn main() {
+LL | |
+LL | | }
+   | |_^
+   = note: requested on the command line with `-W unused-attributes`
+
+warning: 1 warning emitted
+