Improve description of new rustdoc lints

Author: GuillaumeGomez

src/librustdoc/lint.rs

@@ -200,14 +200,14 @@ declare_rustdoc_lint! {
     /// This lint checks for uses of footnote references without definition.
     BROKEN_FOOTNOTE,
     Warn,
-    "footnote reference with no associated definition"
+    "detects footnote references with no associated definition"
 }
 
 declare_rustdoc_lint! {
     /// This lint checks if all footnote definitions are used.
     UNUSED_FOOTNOTE_DEFINITION,
     Warn,
-    "unused footnote definition"
+    "detects unused footnote definitions"
 }
 
 pub(crate) static RUSTDOC_LINTS: Lazy<Vec<&'static Lint>> = Lazy::new(|| {

src/librustdoc/passes/lint/footnotes.rs

@@ -71,20 +71,18 @@ pub(crate) fn visit_item(cx: &DocContext<'_>, item: &Item, hir_id: HirId, dox: &
 
     #[allow(rustc::potential_query_instability)]
     for span in missing_footnote_references {
-        let (ref_span, precise) =
+        let (ref_span, _) =
             source_span_for_markdown_range(tcx, dox, &span, &item.attrs.doc_strings)
                 .unwrap_or_else(|| (item.attr_span(tcx), false));
 
-        if precise {
-            tcx.node_span_lint(crate::lint::BROKEN_FOOTNOTE, hir_id, ref_span, |lint| {
-                lint.primary_message("no footnote definition matching this footnote");
-                lint.span_suggestion(
-                    ref_span.shrink_to_lo(),
-                    "if it should not be a footnote, escape it",
-                    "\\",
-                    Applicability::MaybeIncorrect,
-                );
-            });
-        }
+        tcx.node_span_lint(crate::lint::BROKEN_FOOTNOTE, hir_id, ref_span, |lint| {
+            lint.primary_message("no footnote definition matching this footnote");
+            lint.span_suggestion(
+                ref_span.shrink_to_lo(),
+                "if it should not be a footnote, escape it",
+                "\\",
+                Applicability::MaybeIncorrect,
+            );
+        });
     }
 }

tests/rustdoc-ui/lints/broken-footnote.rs

@@ -1,5 +1,4 @@
 #![deny(rustdoc::broken_footnote)]
-#![allow(rustdoc::unportable_markdown)]
 
 //! Footnote referenced [^1]. And [^2]. And [^bla].
 //!

tests/rustdoc-ui/lints/broken-footnote.stderr

@@ -1,5 +1,5 @@
 error: no footnote definition matching this footnote
-  --> $DIR/broken-footnote.rs:4:45
+  --> $DIR/broken-footnote.rs:3:45
    |
 LL | //! Footnote referenced [^1]. And [^2]. And [^bla].
    |                                             -^^^^^
@@ -13,7 +13,7 @@ LL | #![deny(rustdoc::broken_footnote)]
    |         ^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: no footnote definition matching this footnote
-  --> $DIR/broken-footnote.rs:4:35
+  --> $DIR/broken-footnote.rs:3:35
    |
 LL | //! Footnote referenced [^1]. And [^2]. And [^bla].
    |                                   -^^^

tests/rustdoc-ui/lints/unused-footnote.rs

@@ -1,9 +1,9 @@
-// This test ensures that the rustdoc `unused_footnote` is working as expected.
+// This test ensures that the `rustdoc::unused_footnote` lint is working as expected.
 
 #![deny(rustdoc::unused_footnote_definition)]
 
 //! Footnote referenced. [^2]
 //!
 //! [^1]: footnote defined
 //! [^2]: footnote defined
-//~^^ unused_footnote_definition
+//~^^ ERROR: unused footnote definition