Skip to content

Commit 2f1bd3f

Browse files
committed
Auto merge of #150844 - fmease:mv-ace-tests, r=BoxyUwU
mGCA: Move tests for assoc const bindings (formerly ACE) into dedicated directory & replace more mentions of ACE Split out of PR #150843. As discussed. Somewhat obvious underlying principle: If the test checks basic or core parts of assoc const bindings and nothing else, move it, otherwise leave it even if it contains ACEs. Motivation: It makes a lot easier for me to continue working on ACE efficiently. r? @BoxyUwU
2 parents aefa104 + b144a11 commit 2f1bd3f

50 files changed

Lines changed: 37 additions & 57 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

compiler/rustc_ast/src/ast.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2396,7 +2396,7 @@ impl FnSig {
23962396
/// * the `G<Ty> = Ty` in `Trait<G<Ty> = Ty>`
23972397
/// * the `A: Bound` in `Trait<A: Bound>`
23982398
/// * the `RetTy` in `Trait(ArgTy, ArgTy) -> RetTy`
2399-
/// * the `C = { Ct }` in `Trait<C = { Ct }>` (feature `associated_const_equality`)
2399+
/// * the `C = { Ct }` in `Trait<C = { Ct }>` (feature `min_generic_const_args`)
24002400
/// * the `f(..): Bound` in `Trait<f(..): Bound>` (feature `return_type_notation`)
24012401
#[derive(Clone, Encodable, Decodable, Debug, Walkable)]
24022402
pub struct AssocItemConstraint {

compiler/rustc_hir/src/hir.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3312,7 +3312,7 @@ pub enum ImplItemKind<'hir> {
33123312
/// * the `G<Ty> = Ty` in `Trait<G<Ty> = Ty>`
33133313
/// * the `A: Bound` in `Trait<A: Bound>`
33143314
/// * the `RetTy` in `Trait(ArgTy, ArgTy) -> RetTy`
3315-
/// * the `C = { Ct }` in `Trait<C = { Ct }>` (feature `associated_const_equality`)
3315+
/// * the `C = { Ct }` in `Trait<C = { Ct }>` (feature `min_generic_const_args`)
33163316
/// * the `f(..): Bound` in `Trait<f(..): Bound>` (feature `return_type_notation`)
33173317
#[derive(Debug, Clone, Copy, HashStable_Generic)]
33183318
pub struct AssocItemConstraint<'hir> {

compiler/rustc_hir_analysis/src/hir_ty_lowering/bounds.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,8 +575,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
575575
// FIXME: point at the type params that don't have appropriate lifetimes:
576576
// struct S1<F: for<'a> Fn(&i32, &i32) -> &'a i32>(F);
577577
// ---- ---- ^^^^^^^
578-
// NOTE(associated_const_equality): This error should be impossible to trigger
579-
// with associated const equality constraints.
578+
// NOTE(mgca): This error should be impossible to trigger with assoc const bindings.
580579
self.validate_late_bound_regions(
581580
late_bound_in_projection_ty,
582581
late_bound_in_term,

compiler/rustc_hir_analysis/src/hir_ty_lowering/dyn_trait.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -503,8 +503,7 @@ impl<'tcx> dyn HirTyLowerer<'tcx> + '_ {
503503
// FIXME: point at the type params that don't have appropriate lifetimes:
504504
// struct S1<F: for<'a> Fn(&i32, &i32) -> &'a i32>(F);
505505
// ---- ---- ^^^^^^^
506-
// NOTE(associated_const_equality): This error should be impossible to trigger
507-
// with associated const equality constraints.
506+
// NOTE(mgca): This error should be impossible to trigger with assoc const bindings.
508507
self.validate_late_bound_regions(
509508
late_bound_in_projection_term,
510509
late_bound_in_term,

src/tools/tidy/src/issues.txt

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ ui/asm/issue-99122.rs
3333
ui/asm/x86_64/issue-82869.rs
3434
ui/asm/x86_64/issue-89875.rs
3535
ui/asm/x86_64/issue-96797.rs
36-
ui/associated-consts/issue-102335-const.rs
37-
ui/associated-consts/issue-105330.rs
3836
ui/associated-consts/issue-110933.rs
3937
ui/associated-consts/issue-24949-assoc-const-static-recursion-impl.rs
4038
ui/associated-consts/issue-24949-assoc-const-static-recursion-trait-default.rs
@@ -45,7 +43,6 @@ ui/associated-consts/issue-63496.rs
4543
ui/associated-consts/issue-69020-assoc-const-arith-overflow.rs
4644
ui/associated-consts/issue-88599-ref-self.rs
4745
ui/associated-consts/issue-93775.rs
48-
ui/associated-consts/issue-93835.rs
4946
ui/associated-inherent-types/issue-104260.rs
5047
ui/associated-inherent-types/issue-109071.rs
5148
ui/associated-inherent-types/issue-109299-1.rs
@@ -70,7 +67,6 @@ ui/associated-type-bounds/issue-73818.rs
7067
ui/associated-type-bounds/issue-79949.rs
7168
ui/associated-type-bounds/issue-81193.rs
7269
ui/associated-type-bounds/issue-83017.rs
73-
ui/associated-type-bounds/issue-99828.rs
7470
ui/associated-type-bounds/return-type-notation/issue-120208-higher-ranked-const.rs
7571
ui/associated-types/issue-18655.rs
7672
ui/associated-types/issue-19081.rs
@@ -498,6 +494,9 @@ ui/confuse-field-and-method/issue-18343.rs
498494
ui/confuse-field-and-method/issue-2392.rs
499495
ui/confuse-field-and-method/issue-32128.rs
500496
ui/confuse-field-and-method/issue-33784.rs
497+
ui/const-generics/associated-const-bindings/issue-102335-const.rs
498+
ui/const-generics/associated-const-bindings/issue-105330.rs
499+
ui/const-generics/associated-const-bindings/issue-93835.rs
501500
ui/const-generics/generic_arg_infer/issue-91614.rs
502501
ui/const-generics/generic_const_exprs/const_kind_expr/issue_114151.rs
503502
ui/const-generics/generic_const_exprs/issue-100217.rs

tests/ui/associated-type-bounds/const-projection-err.stock.stderr

Lines changed: 0 additions & 17 deletions
This file was deleted.

tests/ui/associated-consts/assoc-const-eq-ambiguity.rs renamed to tests/ui/const-generics/associated-const-bindings/ambiguity.rs

File renamed without changes.

tests/ui/associated-consts/assoc-const-eq-ambiguity.stderr renamed to tests/ui/const-generics/associated-const-bindings/ambiguity.stderr

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
error[E0222]: ambiguous associated constant `K` in bounds of `Trait0`
2-
--> $DIR/assoc-const-eq-ambiguity.rs:13:25
2+
--> $DIR/ambiguity.rs:13:25
33
|
44
LL | const K: ();
55
| -----------
@@ -17,7 +17,7 @@ LL | fn take0(_: impl Trait0<K = const { }>) {}
1717
T: Parent0<i32>::K = const { }
1818

1919
error[E0222]: ambiguous associated constant `C` in bounds of `Trait1`
20-
--> $DIR/assoc-const-eq-ambiguity.rs:26:25
20+
--> $DIR/ambiguity.rs:26:25
2121
|
2222
LL | const C: i32;
2323
| ------------ ambiguous `C` from `Parent1`

tests/ui/associated-consts/assoc-const-ty-mismatch.rs renamed to tests/ui/const-generics/associated-const-bindings/assoc-const-ty-mismatch.rs

File renamed without changes.

tests/ui/associated-consts/assoc-const-ty-mismatch.stderr renamed to tests/ui/const-generics/associated-const-bindings/assoc-const-ty-mismatch.stderr

File renamed without changes.

0 commit comments

Comments
 (0)