Auto merge of #152856 - bjorn3:remove_no_link_attr, r=<try>

[DO NOT MERGE] Remove #[no_link] attribute

Author: bors

compiler/rustc_attr_parsing/src/attributes/mod.rs

@@ -52,7 +52,6 @@ pub(crate) mod macro_attrs;
 pub(crate) mod must_not_suspend;
 pub(crate) mod must_use;
 pub(crate) mod no_implicit_prelude;
-pub(crate) mod no_link;
 pub(crate) mod non_exhaustive;
 pub(crate) mod path;
 pub(crate) mod pin_v2;

compiler/rustc_attr_parsing/src/attributes/no_link.rs

@@ -41,7 +41,6 @@ use crate::attributes::macro_attrs::*;
 use crate::attributes::must_not_suspend::*;
 use crate::attributes::must_use::*;
 use crate::attributes::no_implicit_prelude::*;
-use crate::attributes::no_link::*;
 use crate::attributes::non_exhaustive::*;
 use crate::attributes::path::PathParser as PathAttributeParser;
 use crate::attributes::pin_v2::*;
@@ -254,7 +253,6 @@ attribute_parsers!(
         Single<WithoutArgs<NoBuiltinsParser>>,
         Single<WithoutArgs<NoCoreParser>>,
         Single<WithoutArgs<NoImplicitPreludeParser>>,
-        Single<WithoutArgs<NoLinkParser>>,
         Single<WithoutArgs<NoMainParser>>,
         Single<WithoutArgs<NoMangleParser>>,
         Single<WithoutArgs<NoStdParser>>,

compiler/rustc_attr_parsing/src/context.rs

@@ -628,11 +628,6 @@ pub static BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[
         template!(NameValueStr: "name", "https://doc.rust-lang.org/reference/items/external-blocks.html#the-link_name-attribute"),
         FutureWarnPreceding, EncodeCrossCrate::Yes
     ),
-    ungated!(
-        no_link, Normal,
-        template!(Word, "https://doc.rust-lang.org/reference/items/extern-crates.html#the-no_link-attribute"),
-        WarnFollowing, EncodeCrossCrate::No
-    ),
     ungated!(
         repr, Normal,
         template!(

compiler/rustc_feature/src/builtin_attrs.rs

@@ -1158,9 +1158,6 @@ pub enum AttributeKind {
     /// Represents `#[no_implicit_prelude]`
     NoImplicitPrelude(Span),
 
-    /// Represents `#[no_link]`
-    NoLink,
-
     /// Represents `#[no_main]`
     NoMain,
 

compiler/rustc_hir/src/attrs/data_structures.rs

@@ -71,7 +71,6 @@ impl AttributeKind {
             NoBuiltins => Yes,
             NoCore(..) => No,
             NoImplicitPrelude(..) => No,
-            NoLink => No,
             NoMain => No,
             NoMangle(..) => Yes, // Needed for rustdoc
             NoStd(..) => No,

compiler/rustc_hir/src/attrs/encode_cross_crate.rs

@@ -1283,11 +1283,7 @@ impl CStore {
                     }
                     None => ident.name,
                 };
-                let dep_kind = if attr::contains_name(&item.attrs, sym::no_link) {
-                    CrateDepKind::MacrosOnly
-                } else {
-                    CrateDepKind::Unconditional
-                };
+                let dep_kind = CrateDepKind::Unconditional;
 
                 let cnum =
                     self.resolve_crate(tcx, name, item.span, dep_kind, CrateOrigin::Extern)?;

compiler/rustc_metadata/src/creader.rs

@@ -275,7 +275,6 @@ impl<'tcx> CheckAttrVisitor<'tcx> {
                     | AttributeKind::NoBuiltins
                     | AttributeKind::NoCore { .. }
                     | AttributeKind::NoImplicitPrelude(..)
-                    | AttributeKind::NoLink
                     | AttributeKind::NoMain
                     | AttributeKind::NoMangle(..)
                     | AttributeKind::NoStd { .. }

compiler/rustc_passes/src/check_attr.rs

@@ -157,8 +157,6 @@ impl Stop {
             sym::must_use |
             // Should be applied to a foreign function or static
             sym::link_name | sym::link_ordinal | sym::link_section |
-            // Should be applied to an `extern crate` item
-            sym::no_link |
             // Should be applied to a free function, impl method or static
             sym::export_name | sym::no_mangle |
             // Should be applied to a `static` variable

src/tools/clippy/clippy_lints/src/empty_line_after.rs

@@ -188,7 +188,6 @@ pub const INERT_ATTRIBUTES: &[BuiltinAttribute] = &[
         DuplicatesOk,
     ),
     ungated!(link_name, Normal, template!(NameValueStr: "name"), FutureWarnPreceding),
-    ungated!(no_link, Normal, template!(Word), WarnFollowing),
     ungated!(repr, Normal, template!(List: "C"), DuplicatesOk, @only_local: true),
     ungated!(export_name, Normal, template!(NameValueStr: "name"), FutureWarnPreceding),
     ungated!(link_section, Normal, template!(NameValueStr: "name"), FutureWarnPreceding),