Auto merge of #155941 - JonathanBrouwer:rollup-Ak66iXR, r=JonathanBrouwer

Rollup of 15 pull requests

Successful merges:

 - #155923 (Subtree sync for rustc_codegen_cranelift)
 - #155930 (Sync from portable simd 2026 04 28)
 - #155850 (Only exclude the #155473 change for 1-byte bool-likes)
 - #151994 (switch to v0 mangling by default on stable)
 - #154325 (Tweak irrefutable let else warning output)
 - #155273 (Lock stable_crate_ids once in create_crate_num)
 - #155361 (Document that CFI diverges from Rust wrt. ABI-compatibility rules)
 - #155692 (disable naked-dead-code-elimination test if no RET mnemonic is available)
 - #155747 (Update documentation for `wasm32-wali-linux-musl` after integrating n…)
 - #155768 (compiletest: Overhaul the code for running an incremental test revision)
 - #155907 (Handle hkl const closures)
 - #155910 (misc stuff from reading borrowck again :))
 - #155913 (Delete the 12 year old fixme)
 - #155920 (remove review queue triagebot mentions)
 - #155936 (Rename `SharedContext::emit_dyn_lint*` into `emit_lint*`)

Author: bors

compiler/rustc_abi/src/lib.rs

@@ -2084,7 +2084,8 @@ impl Niche {
         let distance_end_zero = max_value - v.end;
         // FIXME: this ought to work for `bool` too, but that seems to be hitting a miscompilation
         // <https://github.com/rust-lang/rust/pull/155473#issuecomment-4302036343>
-        if count == 1 && v != (WrappingRange { start: 0, end: 1 }) {
+        let is_bool = size.bytes() == 1 && v == WrappingRange { start: 0, end: 1 };
+        if count == 1 && !is_bool {
             // We only need one, so just pick the one closest to zero.
             // Not only does that obviously use zero if it's possible, but it also
             // simplifies testing things like `Option<char>`, since looking for `-1`

compiler/rustc_attr_parsing/src/attributes/cfg.rs

@@ -224,15 +224,15 @@ pub(crate) fn parse_name_value<S: Stage>(
 
     match cx.sess.psess.check_config.expecteds.get(&name) {
         Some(ExpectedValues::Some(values)) if !values.contains(&value.map(|(v, _)| v)) => cx
-            .emit_dyn_lint_with_sess(
+            .emit_lint_with_sess(
                 UNEXPECTED_CFGS,
                 move |dcx, level, sess| {
                     check_cfg::unexpected_cfg_value(sess, (name, name_span), value)
                         .into_diag(dcx, level)
                 },
                 span,
             ),
-        None if cx.sess.psess.check_config.exhaustive_names => cx.emit_dyn_lint_with_sess(
+        None if cx.sess.psess.check_config.exhaustive_names => cx.emit_lint_with_sess(
             UNEXPECTED_CFGS,
             move |dcx, level, sess| {
                 check_cfg::unexpected_cfg_name(sess, (name, name_span), value).into_diag(dcx, level)

compiler/rustc_attr_parsing/src/attributes/crate_level.rs

@@ -67,7 +67,7 @@ impl<S: Stage> CombineAttributeParser<S> for CrateTypeParser {
                     None,
                 );
                 let span = n.value_span;
-                cx.emit_dyn_lint(
+                cx.emit_lint(
                     UNKNOWN_CRATE_TYPES,
                     move |dcx, level| {
                         UnknownCrateTypes {

compiler/rustc_attr_parsing/src/attributes/diagnostic/do_not_recommend.rs

@@ -24,7 +24,7 @@ impl<S: Stage> SingleAttributeParser<S> for DoNotRecommendParser {
     fn convert(cx: &mut AcceptContext<'_, '_, S>, args: &ArgParser) -> Option<AttributeKind> {
         let attr_span = cx.attr_span;
         if !matches!(args, ArgParser::NoArgs) {
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 |dcx, level| crate::errors::DoNotRecommendDoesNotExpectArgs.into_diag(dcx, level),
                 attr_span,
@@ -33,7 +33,7 @@ impl<S: Stage> SingleAttributeParser<S> for DoNotRecommendParser {
 
         if !matches!(cx.target, Target::Impl { of_trait: true }) {
             let target_span = cx.target_span;
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MISPLACED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| {
                     IncorrectDoNotRecommendLocation { target_span }.into_diag(dcx, level)

compiler/rustc_attr_parsing/src/attributes/diagnostic/mod.rs

@@ -140,7 +140,7 @@ fn merge<T, S: Stage>(
         (Some(_) | None, None) => {}
         (Some((first_span, _)), Some((later_span, _))) => {
             let first_span = *first_span;
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| {
                     IgnoredDiagnosticOption { first_span, later_span, option_name }
@@ -167,14 +167,14 @@ fn parse_list<'p, S: Stage>(
             // We're dealing with `#[diagnostic::attr()]`.
             // This can be because that is what the user typed, but that's also what we'd see
             // if the user used non-metaitem syntax. See `ArgParser::from_attr_args`.
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| NonMetaItemDiagnosticAttribute.into_diag(dcx, level),
                 list.span,
             );
         }
         ArgParser::NoArgs => {
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| {
                     MissingOptionsForDiagnosticAttribute {
@@ -187,7 +187,7 @@ fn parse_list<'p, S: Stage>(
             );
         }
         ArgParser::NameValue(_) => {
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| {
                     MalFormedDiagnosticAttributeLint {
@@ -221,7 +221,7 @@ fn parse_directive_items<'p, S: Stage>(
         let span = item.span();
 
         macro malformed() {{
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| {
                     MalFormedDiagnosticAttributeLint {
@@ -249,7 +249,7 @@ fn parse_directive_items<'p, S: Stage>(
 
         macro duplicate($name: ident, $($first_span:tt)*) {{
             let first_span = $($first_span)*;
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MALFORMED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| IgnoredDiagnosticOption {
                     first_span,
@@ -285,7 +285,7 @@ fn parse_directive_items<'p, S: Stage>(
                         | FormatWarning::PositionalArgument { span }
                         | FormatWarning::IndexedArgument { span }
                         | FormatWarning::DisallowedPlaceholder { span, .. }) = warning;
-                        cx.emit_dyn_lint(
+                        cx.emit_lint(
                             MALFORMED_DIAGNOSTIC_FORMAT_LITERALS,
                             move |dcx, level| warning.into_diag(dcx, level),
                             span,
@@ -295,7 +295,7 @@ fn parse_directive_items<'p, S: Stage>(
                     f
                 }
                 Err(e) => {
-                    cx.emit_dyn_lint(
+                    cx.emit_lint(
                         MALFORMED_DIAGNOSTIC_FORMAT_LITERALS,
                         move |dcx, level| {
                             WrappedParserError {

compiler/rustc_attr_parsing/src/attributes/diagnostic/on_const.rs

@@ -28,7 +28,7 @@ impl<S: Stage> AttributeParser<S> for OnConstParser {
             // so non-constness is still checked in check_attr.rs
             if !matches!(cx.target, Target::Impl { of_trait: true }) {
                 let target_span = cx.target_span;
-                cx.emit_dyn_lint(
+                cx.emit_lint(
                     MISPLACED_DIAGNOSTIC_ATTRIBUTES,
                     move |dcx, level| {
                         DiagnosticOnConstOnlyForTraitImpls { target_span }.into_diag(dcx, level)

compiler/rustc_attr_parsing/src/attributes/diagnostic/on_move.rs

@@ -33,7 +33,7 @@ impl OnMoveParser {
         self.span = Some(span);
 
         if !matches!(cx.target, Target::Enum | Target::Struct | Target::Union) {
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MISPLACED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| DiagnosticOnMoveOnlyForAdt.into_diag(dcx, level),
                 span,

compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unimplemented.rs

@@ -23,7 +23,7 @@ impl OnUnimplementedParser {
         self.span = Some(span);
 
         if !matches!(cx.target, Target::Trait) {
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MISPLACED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| DiagnosticOnUnimplementedOnlyForTraits.into_diag(dcx, level),
                 span,

compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unknown.rs

@@ -35,7 +35,7 @@ impl OnUnknownParser {
 
         if !early && !matches!(cx.target, Target::Use) {
             let target_span = cx.target_span;
-            cx.emit_dyn_lint(
+            cx.emit_lint(
                 MISPLACED_DIAGNOSTIC_ATTRIBUTES,
                 move |dcx, level| {
                     DiagnosticOnUnknownOnlyForImports { target_span }.into_diag(dcx, level)

compiler/rustc_attr_parsing/src/attributes/diagnostic/on_unmatch_args.rs

@@ -25,7 +25,7 @@ impl<S: Stage> AttributeParser<S> for OnUnmatchArgsParser {
             this.span = Some(span);
 
             if !matches!(cx.target, Target::MacroDef) {
-                cx.emit_dyn_lint(
+                cx.emit_lint(
                     MISPLACED_DIAGNOSTIC_ATTRIBUTES,
                     move |dcx, level| DiagnosticOnUnmatchArgsOnlyForMacros.into_diag(dcx, level),
                     span,