re-bless tests

Author: sjwang05

tests/mir-opt/const_promotion_extern_static.FOO-promoted[0].SimplifyCfg-pre-optimizations.after.mir

@@ -1,18 +1,11 @@
 //@ skip-filecheck
 //@ ignore-endian-big
-extern "C" {
-    static X: i32;
-}
 static Y: i32 = 42;
 
 // EMIT_MIR const_promotion_extern_static.BAR.PromoteTemps.diff
 // EMIT_MIR const_promotion_extern_static.BAR-promoted[0].SimplifyCfg-pre-optimizations.after.mir
 static mut BAR: *const &i32 = [&Y].as_ptr();
 
-// EMIT_MIR const_promotion_extern_static.FOO.PromoteTemps.diff
-// EMIT_MIR const_promotion_extern_static.FOO-promoted[0].SimplifyCfg-pre-optimizations.after.mir
-static mut FOO: *const &i32 = [unsafe { &X }].as_ptr();
-
 // EMIT_MIR const_promotion_extern_static.BOP.built.after.mir
 static BOP: &i32 = &13;
 

tests/mir-opt/const_promotion_extern_static.FOO.PromoteTemps.diff

@@ -0,0 +1,20 @@
+// Regression test for #143174.
+
+#![crate_type = "lib"]
+
+type Fun = unsafe extern "C" fn();
+
+struct Foo(Fun);
+
+static FOO: &Foo = &Foo(BAR);
+//~^ ERROR cannot access extern static `BAR` [E0080]
+//~| ERROR use of extern static is unsafe and requires unsafe function or block [E0133]
+
+// Formerly part of `tests/mir-opt/const_promotion_extern_static.rs`.
+// Promotion of extern statics is now rejected entirely.
+static mut BAZ: *const &Fun = [unsafe { &BAR }].as_ptr();
+//~^ ERROR dangling pointer
+
+unsafe extern "C" {
+    static BAR: Fun;
+}

tests/mir-opt/const_promotion_extern_static.rs

@@ -0,0 +1,24 @@
+error[E0080]: cannot access extern static `BAR`
+  --> $DIR/extern-static-in-static-ice-143174.rs:9:25
+   |
+LL | static FOO: &Foo = &Foo(BAR);
+   |                         ^^^ evaluation of `FOO` failed here
+
+error: encountered dangling pointer in final value of mutable static
+  --> $DIR/extern-static-in-static-ice-143174.rs:15:1
+   |
+LL | static mut BAZ: *const &Fun = [unsafe { &BAR }].as_ptr();
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+error[E0133]: use of extern static is unsafe and requires unsafe function or block
+  --> $DIR/extern-static-in-static-ice-143174.rs:9:25
+   |
+LL | static FOO: &Foo = &Foo(BAR);
+   |                         ^^^ use of extern static
+   |
+   = note: extern statics are not controlled by the Rust type system: invalid data, aliasing violations or data races will cause undefined behavior
+
+error: aborting due to 3 previous errors
+
+Some errors have detailed explanations: E0080, E0133.
+For more information about an error, try `rustc --explain E0080`.