revert buffering of KeywordIdents Lint

this also reverts a fix for keywords_idents linting from other files

Author: Bryntet

compiler/rustc_lint/src/builtin.rs

@@ -1901,10 +1901,9 @@ impl KeywordIdents {
             return;
         }
 
-        cx.sess().psess.buffer_lint(
+        cx.emit_span_lint(
             lint,
             ident.span,
-            CRATE_NODE_ID,
             BuiltinKeywordIdents { kw: ident, next: edition, suggestion: ident.span, prefix },
         );
     }

tests/ui/lint/keyword-idents/multi-file.rs

@@ -1,17 +1,14 @@
-#![deny(keyword_idents)]
+#![deny(keyword_idents)] // Should affect the submodule, but doesn't.
 //@ edition: 2015
+//@ known-bug: #132218
+//@ check-pass (known bug; should be check-fail)
+
+// Because `keyword_idents_2018` and `keyword_idents_2024` are pre-expansion
+// lints, configuring them via lint attributes doesn't propagate to submodules
+// in other files.
+// <https://github.com/rust-lang/rust/issues/132218>
 
 #[path = "./auxiliary/multi_file_submod.rs"]
 mod multi_file_submod;
-//~? ERROR `async` is a keyword
-//~? WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018!
-//~? ERROR `await` is a keyword
-//~? WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018!
-//~? ERROR `try` is a keyword
-//~? WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018!
-//~? ERROR `dyn` is a keyword
-//~? WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018!
-//~? ERROR `gen` is a keyword
-//~? WARN this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2024!
 
 fn main() {}