Improve JS source code for settings

Author: GuillaumeGomez

src/librustdoc/html/static/js/settings.js

@@ -43,46 +43,22 @@
                     }
                 }
                 break;
-            case "hide-sidebar":
-                if (value === true) {
-                    addClass(document.documentElement, "hide-sidebar");
-                } else {
-                    removeClass(document.documentElement, "hide-sidebar");
-                }
-                break;
-            case "hide-toc":
-                if (value === true) {
-                    addClass(document.documentElement, "hide-toc");
-                } else {
-                    removeClass(document.documentElement, "hide-toc");
-                }
-                break;
-            case "hide-modnav":
-                if (value === true) {
-                    addClass(document.documentElement, "hide-modnav");
-                } else {
-                    removeClass(document.documentElement, "hide-modnav");
-                }
-                break;
             case "sans-serif-fonts":
                 if (value === true) {
                     addClass(document.documentElement, "sans-serif");
                 } else {
                     removeClass(document.documentElement, "sans-serif");
                 }
                 break;
+            case "hide-sidebar":
+            case "hide-toc":
+            case "hide-modnav":
             case "word-wrap-source-code":
-                if (value === true) {
-                    addClass(document.documentElement, "word-wrap-source-code");
-                } else {
-                    removeClass(document.documentElement, "word-wrap-source-code");
-                }
-                break;
             case "hide-deprecated-items":
                 if (value === true) {
-                    addClass(document.documentElement, "hide-deprecated-items");
+                    addClass(document.documentElement, settingName);
                 } else {
-                    removeClass(document.documentElement, "hide-deprecated-items");
+                    removeClass(document.documentElement, settingName);
                 }
         }
     }

src/librustdoc/html/static/js/storage.js

@@ -319,24 +319,24 @@ updateTheme();
 if (getSettingValue("source-sidebar-show") === "true") {
     addClass(document.documentElement, "src-sidebar-expanded");
 }
-if (getSettingValue("hide-sidebar") === "true") {
-    addClass(document.documentElement, "hide-sidebar");
-}
-if (getSettingValue("hide-toc") === "true") {
-    addClass(document.documentElement, "hide-toc");
-}
-if (getSettingValue("hide-modnav") === "true") {
-    addClass(document.documentElement, "hide-modnav");
-}
 if (getSettingValue("sans-serif-fonts") === "true") {
     addClass(document.documentElement, "sans-serif");
 }
-if (getSettingValue("word-wrap-source-code") === "true") {
-    addClass(document.documentElement, "word-wrap-source-code");
-}
-if (getSettingValue("hide-deprecated-items") === "true") {
-    addClass(document.documentElement, "hide-deprecated-items");
-}
+(function() {
+    const settings = [
+        "hide-sidebar",
+        "hide-toc",
+        "hide-modnav",
+        "word-wrap-source-code",
+        "hide-deprecated-items",
+    ];
+    for (const setting of settings) {
+        if (getSettingValue(setting) === "true") {
+            addClass(document.documentElement, setting);
+        }
+    }
+})();
+
 function updateSidebarWidth() {
     const desktopSidebarWidth = getSettingValue("desktop-sidebar-width");
     if (desktopSidebarWidth && desktopSidebarWidth !== "null") {