remove unnecessary format! calls in favour of .to_string calls

GTimothy · GTimothy · commit 7b1ebf16b2ad · 2026-03-03T20:16:21.000+01:00
diff --git a/compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs b/compiler/rustc_borrowck/src/diagnostics/mutability_errors.rs
@@ -757,7 +757,7 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {
                                     (
                                         val.span.shrink_to_hi().with_hi(index.span.lo() + offset), //remove the
                                         //leading &
-                                        format!(".insert("),
+                                        ".insert(".to_string(),
                                     ),
                                     (
                                         index.span.shrink_to_hi().with_hi(rv.span.lo()),
@@ -778,7 +778,7 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {
                                     (
                                         val.span.shrink_to_hi().with_hi(index.span.lo() + offset), //remove the
                                         //leading &
-                                        format!(".entry("),
+                                        ".entry(".to_string(),
                                     ),
                                     (
                                         index.span.shrink_to_hi().with_hi(rv.span.lo()),
@@ -826,7 +826,7 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {
                                 (val.span.shrink_to_lo(), "if let Some(val) = ".to_string()),
                                 (
                                     val.span.shrink_to_hi().with_hi(index.span.lo()),
-                                    format!(".get_mut("),
+                                    ".get_mut(".to_string(),
                                 ),
                                 (
                                     index.span.shrink_to_hi().with_hi(receiver.span.hi()),

Original file line number	Diff line number	Diff line change
`@@ -757,7 +757,7 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {`
`757`	`757`	`(`
`758`	`758`	`val.span.shrink_to_hi().with_hi(index.span.lo() + offset), //remove the`
`759`	`759`	`//leading &`
`760`		`- format!(".insert("),`
	`760`	`+ ".insert(".to_string(),`
`761`	`761`	`),`
`762`	`762`	`(`
`763`	`763`	`index.span.shrink_to_hi().with_hi(rv.span.lo()),`
`@@ -778,7 +778,7 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {`
`778`	`778`	`(`
`779`	`779`	`val.span.shrink_to_hi().with_hi(index.span.lo() + offset), //remove the`
`780`	`780`	`//leading &`
`781`		`- format!(".entry("),`
	`781`	`+ ".entry(".to_string(),`
`782`	`782`	`),`
`783`	`783`	`(`
`784`	`784`	`index.span.shrink_to_hi().with_hi(rv.span.lo()),`
`@@ -826,7 +826,7 @@ impl<'infcx, 'tcx> MirBorrowckCtxt<'_, 'infcx, 'tcx> {`
`826`	`826`	`(val.span.shrink_to_lo(), "if let Some(val) = ".to_string()),`
`827`	`827`	`(`
`828`	`828`	`val.span.shrink_to_hi().with_hi(index.span.lo()),`
`829`		`- format!(".get_mut("),`
	`829`	`+ ".get_mut(".to_string(),`
`830`	`830`	`),`
`831`	`831`	`(`
`832`	`832`	`index.span.shrink_to_hi().with_hi(receiver.span.hi()),`