Skip to content

Commit 7d15b28

Browse files
committed
reviews addressing
1 parent 5c82915 commit 7d15b28

5 files changed

Lines changed: 5 additions & 19 deletions

File tree

src/bootstrap/src/core/build_steps/test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -973,7 +973,7 @@ impl Step for IntrinsicTest {
973973
const IS_HOST: bool = true;
974974

975975
fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
976-
run.path("library/stdarch/crates/intrinsic-test").path("library/stdarch/crates/core_arch")
976+
run.path("library/stdarch/crates/intrinsic-test")
977977
}
978978

979979
fn make_run(run: RunConfig<'_>) {
@@ -1050,7 +1050,7 @@ impl Step for IntrinsicTest {
10501050
if let Some(runner) = sde_runner {
10511051
cargo.env("CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_RUNNER", runner);
10521052
}
1053-
cargo.delay_failure().run(builder);
1053+
cargo.run(builder);
10541054
}
10551055
}
10561056

src/bootstrap/src/core/builder/cli_paths/snapshots/x_test.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,6 @@ expression: test
181181
[Test] test::RustcBook
182182
targets: [x86_64-unknown-linux-gnu]
183183
- Set({test::src/doc/rustc})
184-
[Test] test::IntrinsicTest
185-
targets: [x86_64-unknown-linux-gnu]
186-
- Set({test::library/stdarch/crates/core_arch})
187-
- Set({test::library/stdarch/crates/intrinsic-test})
188184
[Test] test::StdarchVerify
189185
targets: [x86_64-unknown-linux-gnu]
190186
- Set({test::library/stdarch/crates/stdarch-verify})

src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_library.snap

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,9 @@ expression: test library
1818
- Set({test::library/sysroot})
1919
- Set({test::library/test})
2020
- Set({test::library/unwind})
21-
[Test] test::IntrinsicTest
22-
targets: [x86_64-unknown-linux-gnu]
23-
- Set({test::library/stdarch/crates/core_arch})
24-
- Set({test::library/stdarch/crates/intrinsic-test})
2521
[Test] test::StdarchVerify
2622
targets: [x86_64-unknown-linux-gnu]
2723
- Set({test::library/stdarch/crates/stdarch-verify})
28-
24+
[Test] test::IntrinsicTest
25+
targets: [x86_64-unknown-linux-gnu]
26+
- Set({test::library/stdarch/crates/intrinsic-test})

src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_coverage.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,6 @@ expression: test --skip=coverage
180180
[Test] test::RustcBook
181181
targets: [x86_64-unknown-linux-gnu]
182182
- Set({test::src/doc/rustc})
183-
[Test] test::IntrinsicTest
184-
targets: [x86_64-unknown-linux-gnu]
185-
- Set({test::library/stdarch/crates/core_arch})
186-
- Set({test::library/stdarch/crates/intrinsic-test})
187183
[Test] test::StdarchVerify
188184
targets: [x86_64-unknown-linux-gnu]
189185
- Set({test::library/stdarch/crates/stdarch-verify})

src/bootstrap/src/core/builder/cli_paths/snapshots/x_test_skip_tests.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,6 @@ expression: test --skip=tests
144144
[Test] test::RustcBook
145145
targets: [x86_64-unknown-linux-gnu]
146146
- Set({test::src/doc/rustc})
147-
[Test] test::IntrinsicTest
148-
targets: [x86_64-unknown-linux-gnu]
149-
- Set({test::library/stdarch/crates/core_arch})
150-
- Set({test::library/stdarch/crates/intrinsic-test})
151147
[Test] test::StdarchVerify
152148
targets: [x86_64-unknown-linux-gnu]
153149
- Set({test::library/stdarch/crates/stdarch-verify})

0 commit comments

Comments
 (0)