Skip to content

Commit 8004795

Browse files
committed
supports_c_variadic_definitions: extend checklist for new targets
1 parent 485ec3f commit 8004795

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

  • compiler/rustc_target/src/spec

compiler/rustc_target/src/spec/mod.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2226,6 +2226,8 @@ impl Target {
22262226
// `clang`, or we should understand and document why it deviates.
22272227
// - Ensure that `va_arg` is implemented in rustc. For stable targets we don't rely on
22282228
// the LLVM implementation, it has historically caused miscompilations.
2229+
// - Ensure that LLVM's `va_end` for this target is a NOP.
2230+
// - Ensure that LLVM's `va_copy` for this target is equivalent to `memcpy`.
22292231
// - The `tests/ui/c-variadic/roundtrip.rs` test must pass for the target. It may
22302232
// need slight modifications for embedded targets, that's fine.
22312233
// - Check that calling c-variadic functions defined in Rust can be called from C.

0 commit comments

Comments
 (0)